Skip to content

Fix supportedMethods property type #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2017
Merged

Fix supportedMethods property type #310

merged 3 commits into from
Nov 3, 2017

Conversation

1000ch
Copy link
Contributor

@1000ch 1000ch commented Oct 16, 2017

According to https://www.w3.org/TR/payment-request/#paymentmethoddata-dictionary, https://www.w3.org/TR/payment-request/#paymentdetailsmodifier-dictionary.

interface PaymentMethodData {
    data?: any;
    supportedMethods?: string[];
}

should be

interface PaymentMethodData {
    data?: any;
    supportedMethods?: string;
}

Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the .xml files, change https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json instead. also make sure to copy your generated/* into baselines/* and include the new baselines before you submit a change.

@msftclas
Copy link

msftclas commented Oct 20, 2017

CLA assistant check
All CLA requirements met.

@1000ch
Copy link
Contributor Author

1000ch commented Oct 20, 2017

@mhegazy Thank you for review.

@mhegazy mhegazy merged commit 9ce3973 into microsoft:master Nov 3, 2017
@1000ch 1000ch mentioned this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants