fix querySelector method #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the delay. can you refresh the PR? |
|
done. |
mhegazy
reviewed
May 13, 2017
baselines/dom.generated.d.ts
Outdated
| @@ -13736,8 +13736,10 @@ interface NavigatorUserMedia { | |||
|
|
|||
| interface NodeSelector { | |||
| querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null; | |||
| querySelector<E extends Element>(selectors: string): E | null; | |||
There was a problem hiding this comment.
why not combine both signatures as:
querySelector<E extends Element = Element>(selectors: string): E | null;There was a problem hiding this comment.
I did not know generic default... I fix it 😃
AustinMatherne
suggested changes
Jun 9, 2017
baselines/dom.generated.d.ts
Outdated
| querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K]; | ||
| querySelectorAll<E extends Element>(selectors: string): NodeListOf<E>; |
There was a problem hiding this comment.
Can we combine these, too?
querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;
|
@mhegazy anything holding this PR up? This makes testing the DOM much nicer in Angular 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12568