Skip to content

Commit 6ce6df6

Browse files
committed
revert nodelists to using numeric keys
1 parent 80dbebf commit 6ce6df6

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

baselines/dom.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10828,7 +10828,7 @@ interface NodeList {
1082810828
* @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the list.
1082910829
* @param thisArg An object to which the this keyword can refer in the callbackfn function. If thisArg is omitted, undefined is used as the this value.
1083010830
*/
10831-
forEach(callbackfn: (value: Node, key: Node, parent: NodeList) => void, thisArg?: any): void;
10831+
forEach(callbackfn: (value: Node, key: number, parent: NodeList) => void, thisArg?: any): void;
1083210832
[index: number]: Node;
1083310833
}
1083410834

baselines/dom.iterable.generated.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ interface NamedNodeMap {
109109
}
110110

111111
interface NodeList {
112-
[Symbol.iterator](): IterableIterator<[Node, Node]>;
112+
[Symbol.iterator](): IterableIterator<Node>;
113113
/**
114114
* Returns an array of key, value pairs for every entry in the list.
115115
*/
116-
entries(): IterableIterator<[Node, Node]>;
116+
entries(): IterableIterator<[number, Node]>;
117117
/**
118118
* Returns an list of keys in the list.
119119
*/
120-
keys(): IterableIterator<Node>;
120+
keys(): IterableIterator<number>;
121121
/**
122122
* Returns an list of values in the list.
123123
*/

inputfiles/overridingTypes.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1600,15 +1600,6 @@
16001600
}
16011601
]
16021602
},
1603-
"NodeList": {
1604-
"name": "NodeList",
1605-
"iterator": {
1606-
"kind": "iterable",
1607-
"type": [{
1608-
"override-type": "Node"
1609-
}]
1610-
}
1611-
},
16121603
"ServiceWorkerContainer": {
16131604
"name": "ServiceWorkerContainer",
16141605
"methods": {

0 commit comments

Comments
 (0)