Skip to content

Commit 2a933e0

Browse files
committed
reintroduce getelementsByTagName overrides
1 parent 047c17b commit 2a933e0

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

baselines/dom.generated.d.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4335,6 +4335,9 @@ interface Document extends Node, NonElementParentNode, DocumentOrShadowRoot, Par
43354335
* Retrieves a collection of objects based on the specified element name.
43364336
* @param name Specifies the name of an element.
43374337
*/
4338+
getElementsByTagName<K extends keyof HTMLElementTagNameMap>(qualifiedName: K): NodeListOf<HTMLElementTagNameMap[K]>;
4339+
getElementsByTagName<K extends keyof SVGElementTagNameMap>(qualifiedName: K): NodeListOf<SVGElementTagNameMap[K]>;
4340+
getElementsByTagName(qualifiedName: string): NodeListOf<Element>;
43384341
/**
43394342
* Causes the element to receive the focus and executes the code specified by the onfocus event.
43404343
*/
@@ -4677,6 +4680,9 @@ interface Element extends Node, ParentNode, NonDocumentTypeChildNode, ChildNode,
46774680
getBoundingClientRect(): ClientRect | DOMRect;
46784681
getClientRects(): ClientRectList | DOMRectList;
46794682
getElementsByClassName(classNames: string): NodeListOf<Element>;
4683+
getElementsByTagName<K extends keyof HTMLElementTagNameMap>(qualifiedName: K): NodeListOf<HTMLElementTagNameMap[K]>;
4684+
getElementsByTagName<K extends keyof SVGElementTagNameMap>(qualifiedName: K): NodeListOf<SVGElementTagNameMap[K]>;
4685+
getElementsByTagName(qualifiedName: string): NodeListOf<Element>;
46804686
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/1999/xhtml", localName: string): HTMLCollectionOf<HTMLElement>;
46814687
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/2000/svg", localName: string): HTMLCollectionOf<SVGElement>;
46824688
getElementsByTagNameNS(namespaceURI: string, localName: string): HTMLCollectionOf<Element>;

src/emitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ export function emitWebIDl(webidl: Browser.WebIdl, flavor: Flavor) {
371371

372372
/// Emit overloads for the getElementsByTagName method
373373
function emitGetElementsByTagNameOverloads(m: Browser.Method) {
374-
if (matchParamMethodSignature(m, "getElementsByTagName", "NodeList", "string")) {
374+
if (matchParamMethodSignature(m, "getElementsByTagName", "HTMLCollection", "string")) {
375375
printer.printLine(`getElementsByTagName<K extends keyof HTMLElementTagNameMap>(${m.signature[0].param![0].name}: K): NodeListOf<HTMLElementTagNameMap[K]>;`);
376376
printer.printLine(`getElementsByTagName<K extends keyof SVGElementTagNameMap>(${m.signature[0].param![0].name}: K): NodeListOf<SVGElementTagNameMap[K]>;`);
377377
printer.printLine(`getElementsByTagName(${m.signature[0].param![0].name}: string): NodeListOf<Element>;`);

0 commit comments

Comments
 (0)