Move system_clock from <__msvc_chrono.hpp> to <chrono>
#5105
+99
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
throughput
StephanTLavavej
approved these changes
Nov 21, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this throughput improvement! It's going to break some source code (we found 6 projects in our Real World Code test suite that were affected), so never let it be said that we're unwilling to make disruptive but righteous changes! 😹 💻 ⏰ |
This was referenced Nov 22, 2024
This was referenced Nov 26, 2024
This was referenced Nov 27, 2024
This was referenced Nov 28, 2024
7 tasks
7 tasks
DavidSpickett
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Dec 6, 2024
I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in `llvm`. It must add include `<chrono>` to fix this error. Compiler error with this STL change: ``` D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.h(79): error C2039: 'system_clock': is not a member of 'std::chrono' D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C3083: 'system_clock': the symbol to the left of a '::' must be a type D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C2039: 'now': is not a member of 'std::chrono' ```
This was referenced Dec 11, 2024
6 tasks
7 tasks
This was referenced Feb 7, 2025
mos9527
pushed a commit
to mos9527/goo-engine
that referenced
this pull request
Feb 21, 2025
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 25, 2025
I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in `llvm`. It must add include `<chrono>` to fix this error. Compiler error with this STL change: ``` D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.h(79): error C2039: 'system_clock': is not a member of 'std::chrono' D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C3083: 'system_clock': the symbol to the left of a '::' must be a type D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C2039: 'now': is not a member of 'std::chrono' ``` (cherry picked from commit 72aefbb)
This was referenced Feb 28, 2025
Merged
1 task
uebian
added a commit
to projectchrono/chrono
that referenced
this pull request
Mar 30, 2025
rserban
pushed a commit
to projectchrono/chrono
that referenced
this pull request
Mar 31, 2025
* Fix the blaze_INCLUDE_DIR setting for macosci
* Use absolute home path for blaze on osx CI/CD pipeline
* Avoid using FAIL in non-test function
* Update CUDA toolkit version to 12.8 in CI configuration and packaging scripts
* Use NVIDIA's official docker container instead of our self-built one
* Use Intel oneAPI+CUDA container
* Load intel oneapi
* Use ${CASCADE_INSTALL_DIR}/build instead of ${CASCADE_INSTALL_DIR}/atm
to make it consistent in our upgraded docker
* Build opencascade
* Eliminate the noisy information in the CI/CD output
* Fix the target dir of opencascade
* Remove OCCT_INSTALL_BIN_LETTER from opencascade
* Use external installation location
* Use CMAKE_INSTALL_PREFIX to specify prefix
* Fix the syntax error in the buildOCCT script
* Use pre-built opencascade
* Manually include chrono to make it compatible with microsoft/STL#5105
* Build VSG before running test on Windows
* Remove additional character in Windows's testing pipeline
* Change the vsg library path to Windows's style
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4457 removed
_To_timespec64_sys_10_day_clamped,<mutex>and friends no longer depend onsystem_clock, sosystem_clockcan be moved back to<chrono>.This PR also moves
high_resolution_clockandchrono_literalsto<chrono>since they are not used in STL headers.