Skip to content

PSScriptAnalyzer and VS Code tooling #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2020

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jun 6, 2020

Description

This adds the following files:

  • launch.json - used by vscode in order to debug PowerShellForGitHub with ease
  • PSScriptAnalyzerSettings.psd1 - used by PSSA to check syntax and also by VS Code to show problems for all rules

Issues Fixed

N/A

References

PSSA Rules: https://github.com/PowerShell/PSScriptAnalyzer/tree/master/RuleDocumentation
Specifically: https://github.com/PowerShell/PSScriptAnalyzer/blob/master/RuleDocumentation/UseCompatibleSyntax.md

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis
    is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

rjmholt
rjmholt previously approved these changes Jun 7, 2020
# All default rules are also enabled.
@{
Rules = @{
PSUseCompatibleSyntax = @{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@HowardWolosky HowardWolosky added the tooling Changes to the developer tooling for the project label Jun 8, 2020
Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Thanks for doing this.
One additional request before merging in.

@HowardWolosky
Copy link
Contributor

@TylerLeonhardt - Sorry for the delay on getting this merged. If you can get the merge conflict resolved, I'll get this merged in. Thanks again for your efforts here.

HowardWolosky
HowardWolosky previously approved these changes Jun 19, 2020
@TylerLeonhardt
Copy link
Member Author

done

@HowardWolosky
Copy link
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky merged commit 06f596e into microsoft:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to the developer tooling for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants