Skip to content

Typo in Update-GitHubRepository variable #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amis92 opened this issue Sep 24, 2019 · 1 comment
Closed

Typo in Update-GitHubRepository variable #136

amis92 opened this issue Sep 24, 2019 · 1 comment
Labels
bug This relates to a bug in the existing module.

Comments

@amis92
Copy link

amis92 commented Sep 24, 2019

A typo results in an incorrect URL being built. Because the variable is misspelled, the repository name is not appended to the URL.

'UriFragment' = "repos/$OwnerName/$ReposistoryName"

Fix:

- 'UriFragment' = "repos/$OwnerName/$ReposistoryName"
+ 'UriFragment' = "repos/$OwnerName/$RepositoryName"
@HowardWolosky
Copy link
Member

Once again, great catch @amis92.

This was the only occurrence of this specific typo throughout the project.

I believe these errors you've found to be fairly abnormal errors relative to the rest of the project, and definitely should have been caught by proper tests. I'll get a separate issue opened to increase the testing for this file.

Fixed by #137

@HowardWolosky HowardWolosky added the bug This relates to a bug in the existing module. label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This relates to a bug in the existing module.
Projects
None yet
Development

No branches or pull requests

2 participants