ports/mimxrt/boards/MIMXRT1060_EVK: Enabled led class for MIMXRT1060_EVK #6117
Conversation
| #define MICROPY_HW_LED_PIN 9 | ||
| // MIMXRT1060_EVK has 1 user LED | ||
| #define MICROPY_HW_LED1_PIN (GPIO_AD_B0_09) | ||
| #define MICROPY_HW_LED_ON(pin) (mp_hal_pin_high(pin)) |
There was a problem hiding this comment.
According to my understanding of the schematics the user LED is pulled up to 3.3V supply. To switch it on pin should be pulled low I believe.
| // MIMXRT1060_EVK has 1 user LED | ||
| #define MICROPY_HW_LED1_PIN (GPIO_AD_B0_09) | ||
| #define MICROPY_HW_LED_ON(pin) (mp_hal_pin_high(pin)) | ||
| #define MICROPY_HW_LED_OFF(pin) (mp_hal_pin_low(pin)) |
There was a problem hiding this comment.
Respectively here. To switch it off, pin should be pulled high.
board. - Enabled led class for MIMXRT1060_EVK.
Albort12138
force-pushed
the
feature/enable-led-class-for-mimxrt1060_evk
branch
from
6444f75 to
b90ee45
Compare
Yes, you are right, that's my fault, I have updated the PR. |
No problem. I made the same mistake with my PR for adding support to 1020EVK 😄. |
Thank you very much! So you are now supporting 1020EVK? If it is OK, can you please share your plan for the support of the mimxrt port. So that we can avoid doing the duplicate work😊. |
Well that is the board I have sitting on my desk hence I am eager to add it to the As you know I started working on the |
|
Thanks for this! Rebased and merged in e0d539f |
implement `from __future__ import annotations`
Backport from __future__ import annotations from micropython#6117
board.