Upstream changed from 'master' to 'main' #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marks Add compiletime benchmarks and fix performance regression
add eval (-e) expression evaluation to command line
Split dotty.tests.filter by comma, to select multiple
Format compiler crash stack traces
This is a test
... and drop the old ElimByName.
I tried to extend specialization to all context functions, not just ones of 0 arity. But that runs into problems for dependent context functions, since the necessary casts get complicated. Since context functions over primitive types are an anti-pattern anyway I don't think we need to optimize this case, after all.
- Split out forward reference checks and cross version (i.e. experimental/deprecated) checks into their own miniphases. These have nothing to do with the core tasks of RefChecks. - Move RefChecks earlier in the pipeline, so that it is not affected by ElimByName's questionable type manipulations.
Fix byte code generation for by-name parameters
Perform the overriding checks after elimByName. I observed some problem with catsEffect2, where a super accessor method with a `() ?=> T` parameter was compared with a corresponding super accessor method with a `=> T` parameter. One of these methods was generated before elimByName, the other after. So comparing them at phase elimRepeated + 1 gave two different types. The problem is fixed by comparing after elimByName, which means that the type of the second method is converted to match the first.
Fix vulnerable dependency
Fix checkNoModuleClash & avoid types with less precision loss
Improve typer traces
Scala 2.13.8 (was 2.13.6)
The error message falsely referred to missing support for early definitions in the example, but none were present. Fixes #14326
Don't lift try-catch statements that are already in local functions
Scaladoc: Add member position IDs to anchors in searchbar
Scaladoc: Fix rendering dependent function types
Scaladoc: Follow renames in content contributors script
fix typo in docs example capability checking
Set zero span for synthetic enum import selector
When we create a synthetic companion object, for exmaple for enums, all the value definitions are put into it and the there are actually multiple trees that contain the position we are itnerested in. Now, NavigateAST.pathTo takes in multiple trees since the method is already able to find the best fit.
Parse empty arguments in (invalid) `Apply` more often
Disable type simplify in unpickler
Search all source trees for a given span
Set zero span for synthetic tuple type
Find inline calls inserted in synthetic members
|
merge failure |
michelou
pushed a commit
that referenced
this pull request
Jan 22, 2024
`given ... with` or `given ... = new { ... }` kinds of definitions now follow
the old rules. This allows recursive `given...with` definitions as they are
found in protoQuill.
We still have the old check in a later phase against directly recursive methods.
Of the three loops in the original i15474 we now detect #2 and #3 with new new
restrictions. #1 slips through since it is a loop involving a `given...with` instance
of `Conversion`, but is caught later with the recursive method check.
Previously tests #1 and #3 were detected with the recursive methods check and #2 slipped
through altogether.
The new rules are enough for defining simple givens with `=` without fear of looping.
michelou
pushed a commit
that referenced
this pull request
Jan 26, 2025
According to [#1][#1] this is valid syntax: java.lang.@nonnull String [#1]: https://checkerframework.org/jsr308/specification/java-annotation-design.html#qualified-type-syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize 'scala3-pandoc' with upstream main.