Skip to content

Commit aa9c9ba

Browse files
huydhnfacebook-github-bot
authored andcommitted
Clean up AWS credentials when building wheels (#1626)
Summary: This fixes the failures when building torchrec wheel using Nova build job. Note that the credential `AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID` has been revoked and we are not using it anymore. I can see it is still used in `.github/workflows/release_build.yml`, so please take priority action to: * Either switch to ODIC like how we do it in Nova pytorch/test-infra#4865. Please reach out to me if you need help on this. * Or remove the workflow if it has been replaced by Nova. Pull Request resolved: #1626 Reviewed By: henrylhtsang Differential Revision: D52737705 Pulled By: huydhn fbshipit-source-id: 79254f42666c6a444973a6d9bd5c13c43ebed0f6
1 parent fb25bf2 commit aa9c9ba

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/build-wheels-linux.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ on:
1212
- v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+
1313
workflow_dispatch:
1414

15+
permissions:
16+
id-token: write
17+
contents: read
18+
1519
jobs:
1620
generate-matrix:
1721
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
@@ -58,6 +62,3 @@ jobs:
5862
package-name: torchrec
5963
smoke-test-script: ""
6064
trigger-event: ${{ github.event_name }}
61-
secrets:
62-
AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID: ${{ secrets.AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID }}
63-
AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY: ${{ secrets.AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY }}

0 commit comments

Comments
 (0)