Commit d0032e0
Disable pybind11's GIL checks (#325)
Summary:
pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246
This feature has already uncovered several instances of undefined behavior in several Python extensions.
However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245
This PR disables those checks, which will in turn allow PyTorch to upgrade.
Note that this code already has known potential GIL issues:
https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59
Pull Request resolved: #325
Reviewed By: PaliC
Differential Revision: D47518187
Pulled By: albanD
fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea51 parent bd1c76f commit d0032e0
1 file changed
+8
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
12 | 20 | | |
13 | 21 | | |
14 | 22 | | |
| |||
0 commit comments