-
Notifications
You must be signed in to change notification settings - Fork 100
Add documents and embbedings database metrics to stats response #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alirexaa
wants to merge
2
commits into
meilisearch:main
Choose a base branch
from
Alirexaa:update-stats-response
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -1795,9 +1795,20 @@ impl<'a, Http: HttpClient> AsRef<IndexUpdater<'a, Http>> for IndexUpdater<'a, Ht | |||||||
#[derive(Debug, Clone, Deserialize)] | ||||||||
#[serde(rename_all = "camelCase")] | ||||||||
pub struct IndexStats { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets also add more doc-comments here
Suggested change
|
||||||||
/// Total number of documents in an index | ||||||||
pub number_of_documents: usize, | ||||||||
/// If `true`, the index is still processing documents and attempts to search will result in undefined behavior | ||||||||
pub is_indexing: bool, | ||||||||
/// Shows every field in the index along with the total number of documents containing that field in said index | ||||||||
pub field_distribution: HashMap<String, usize>, | ||||||||
/// Storage space claimed by all documents in the index in bytes | ||||||||
pub raw_document_db_size: usize, | ||||||||
/// Total size of the documents stored in an index divided by the number of documents in that same index | ||||||||
pub avg_document_size: usize, | ||||||||
/// Total number of documents with at least one embedding | ||||||||
pub number_of_embedded_documents: usize, | ||||||||
/// Total number of embeddings in an index | ||||||||
pub number_of_embeddings: usize, | ||||||||
} | ||||||||
|
||||||||
/// An [`IndexesQuery`] containing filter and pagination parameters when searching for [Indexes](Index). | ||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking about it, this should also be
non_exhaustive
.There are bound to be more stats in the future