-
Notifications
You must be signed in to change notification settings - Fork 93
Drop Node 18 support #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node 18 support #1927
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
- Coverage 99.02% 99.01% -0.01%
==========================================
Files 18 18
Lines 1429 1418 -11
Branches 303 299 -4
==========================================
- Hits 1415 1404 -11
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThe changes update the minimum supported Node.js version from 18 to 20 across documentation, CI workflows, Docker configuration, TypeScript, and build tooling. Code previously accommodating Node.js 18 polyfills is removed. Build and test targets are updated to ES2023 and Node.js 20/22. Minor internal symbol changes improve timeout error identification. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI System
participant Node.js Environment
Developer->>CONTRIBUTING.md: Reads requirements (Node.js 20+)
CI System->>Node.js Environment: Runs tests on Node.js 20 and 22
CI System->>docker-compose.yml: Uses node:22 image
Developer->>tsconfig.json: Compiles with ES2023 target
Developer->>vite.config.ts: Builds with ES2023 target
src/token.ts->>Global Crypto: Uses crypto directly (no polyfill)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @flevi29
Let's merge this 🔥
Pull Request
What does this PR do?
is about to enterentered End Of Life period, so it's time to drop support:https://github.com/nodejs/Release?tab=readme-ov-file#release-schedulehttps://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releasesToken generation and aborting requests might stop working for Node.js 18 users.
Summary by CodeRabbit