Skip to content

Drop Node 18 support #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

Drop Node 18 support #1927

merged 4 commits into from
Jun 2, 2025

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Apr 22, 2025

Pull Request

What does this PR do?

Token generation and aborting requests might stop working for Node.js 18 users.

Summary by CodeRabbit

  • Chores
    • Updated Node.js version support to require a minimum of Node.js 20 (previously 18), reflected in documentation, Docker configuration, and test workflows.
    • Adjusted TypeScript and build targets to ES2023 to align with updated Node.js support.
  • Bug Fixes
    • Improved internal error identification for timeout scenarios.
  • Documentation
    • Updated contributing guide to reflect new Node.js version requirements.

@flevi29 flevi29 added the breaking-change The related changes are breaking for the users label Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (45eabe1) to head (b4ce97a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
- Coverage   99.02%   99.01%   -0.01%     
==========================================
  Files          18       18              
  Lines        1429     1418      -11     
  Branches      303      299       -4     
==========================================
- Hits         1415     1404      -11     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strift Strift added the dependencies Pull requests that update a dependency file label Apr 22, 2025
@Strift Strift changed the title Remove all Node.js 18 references, adapt code to version 20 Drop Node 18 support Apr 22, 2025
Copy link

coderabbitai bot commented May 19, 2025

Walkthrough

The changes update the minimum supported Node.js version from 18 to 20 across documentation, CI workflows, Docker configuration, TypeScript, and build tooling. Code previously accommodating Node.js 18 polyfills is removed. Build and test targets are updated to ES2023 and Node.js 20/22. Minor internal symbol changes improve timeout error identification.

Changes

File(s) Change Summary
.github/workflows/meilisearch-prototype-tests.yml
.github/workflows/pre-release-tests.yml
.github/workflows/tests.yml
Node.js 18 removed from test matrices; integration tests now run only on Node.js 20 and 22.
CONTRIBUTING.md Updated minimum required Node.js version from 18 to 20 in the development requirements section.
docker-compose.yml Changed Node.js Docker image for package service from node:18 to node:22.
tsconfig.json Compilation target updated from ES2022 to ES2023; comment updated for Node.js 20 context.
vite.config.ts Build target for CJS updated to "es2023"; removed CJS-specific rollup options; UMD footer script adjusted.
src/token.ts Removed Node.js 18 crypto polyfill logic; sign now uses global crypto directly.
src/http-requests.ts Changed TIMEOUT_ID from {} to Symbol("<timeout>") for timeout error identification.
src/task.ts Changed TIMEOUT_ID from {} to Symbol("<task timeout>") for task timeout error identification.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI System
    participant Node.js Environment

    Developer->>CONTRIBUTING.md: Reads requirements (Node.js 20+)
    CI System->>Node.js Environment: Runs tests on Node.js 20 and 22
    CI System->>docker-compose.yml: Uses node:22 image
    Developer->>tsconfig.json: Compiles with ES2023 target
    Developer->>vite.config.ts: Builds with ES2023 target
    src/token.ts->>Global Crypto: Uses crypto directly (no polyfill)
Loading

Poem

🐇
Goodbye to Node 18,
Now 20’s on the scene!
Tests and builds are shiny new,
With ES2023 in view.
Crypto’s clear, the code is tight—
This rabbit hops with future’s light!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30b147e and b4ce97a.

📒 Files selected for processing (1)
  • src/task.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/task.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: integration-tests (Node.js 22)
  • GitHub Check: integration-tests (Node.js 20)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Strift Strift enabled auto-merge June 2, 2025 02:16
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @flevi29

Let's merge this 🔥

@Strift Strift added this pull request to the merge queue Jun 2, 2025
Merged via the queue into meilisearch:main with commit bea31ee Jun 2, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants