implement better support for floats #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change uses `fround` when available to make a better decision on if a number is a 32 or 64 bit floating point number. This means that we can more safely use floats in msgpack without losing precision. In the case where `Math.fround` is not defined (I'M LOOKIN AT YOU, IE10), this code defaults to using a float64 so that we don't accidentally lose precision like we did with the previous implementation
|
Good work! Would you like to help maintaining this library? You are probably using it more than myself at this point. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change uses
froundwhen available to make a better decision onif a number is a 32 or 64 bit floating point number. This means that
we can more safely use floats in msgpack without losing precision.
In the case where
Math.froundis not defined (I'M LOOKIN AT YOU, IE10),this code defaults to using a float64 so that we don't accidentally lose
precision like we did with the previous implementation