Skip to content

Commit 72c75c6

Browse files
authored
Merge pull request #1050 from mbifulco/feat/speed-up-playwright
feat: speed up playwright with prebuilt image
2 parents a0b9886 + df7367e commit 72c75c6

File tree

1 file changed

+5
-17
lines changed

1 file changed

+5
-17
lines changed

.github/workflows/test-e2e.yml

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ jobs:
99
playwright:
1010
timeout-minutes: 7
1111
runs-on: ubuntu-latest
12+
container:
13+
image: mcr.microsoft.com/playwright:v1.54.1-noble
14+
options: --user 1001
1215
env:
1316
CONVERTKIT_API_SECRET: ${{ secrets.CONVERTKIT_API_SECRET }}
1417
CONVERTKIT_WEBHOOK_SECRET: ${{ secrets.CONVERTKIT_WEBHOOK_SECRET }}
@@ -28,26 +31,11 @@ jobs:
2831
- uses: actions/setup-node@v4
2932
with:
3033
node-version: lts/*
34+
cache: 'pnpm'
3135

32-
- name: Get pnpm store directory
33-
id: pnpm-cache
34-
run: |
35-
echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT
36-
37-
- name: Setup pnpm cache
38-
uses: actions/cache@v4
39-
with:
40-
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
41-
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
42-
restore-keys: |
43-
${{ runner.os }}-pnpm-store-
44-
45-
- name: Install deps (with cache)
36+
- name: Install deps
4637
run: pnpm install
4738

48-
- name: Install Playwright Browsers
49-
run: pnpm exec playwright install --with-deps
50-
5139
- name: Run Playwright tests
5240
run: pnpm exec playwright test
5341

0 commit comments

Comments
 (0)