Skip to content

Support vendor extensions in anyOf allOf oneOf for OAS 3.1 #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simonbility
Copy link

@simonbility simonbility commented May 16, 2025

Hi, thanks for a great library.

I noticed that for anyOf allOf oneOf schemas the vendor-extensions don't seem to get parsed.

I tweaked the parsing code, that seemed to skip it because of a early return, to handle that, and also added some test.

Please let me know if theres anything else i can contribute

@mattpolzin
Copy link
Owner

Thanks for the fix! I haven't had time to review yet but I'll try and get this reviewed in the next few days.

@mattpolzin mattpolzin self-requested a review May 17, 2025 15:33
@mattpolzin mattpolzin changed the title Support vendor extensions in anyOf allOf oneOf Support vendor extensions in anyOf allOf oneOf for OAS 3.1 May 18, 2025
@mattpolzin
Copy link
Owner

Looks great! Thanks.

@mattpolzin mattpolzin merged commit a21615e into mattpolzin:main May 18, 2025
25 checks passed
mattpolzin added a commit that referenced this pull request May 18, 2025
mattpolzin added a commit that referenced this pull request May 18, 2025
mattpolzin added a commit that referenced this pull request May 19, 2025
mattpolzin added a commit that referenced this pull request May 19, 2025
mattpolzin added a commit that referenced this pull request May 19, 2025
…OAS30

Port fix from #409 over to the OAS 3.0 module
@simonbility simonbility deleted the feature/support-vendor-extensions-in-anyof-allof-oneof branch May 19, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants