Skip to content

Add support for specifying JSON schema dialects #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattpolzin opened this issue Mar 7, 2021 · 2 comments
Open

Add support for specifying JSON schema dialects #202

mattpolzin opened this issue Mar 7, 2021 · 2 comments

Comments

@mattpolzin
Copy link
Owner

mattpolzin commented Mar 7, 2021

See Specifying Schema Dialects in the new spec.

This change will impact both the JSONSchema type and the root document type (where a default dialect is allowed to be specified).

Note that OpenAPIKit will not (at this time) do anything with values of these fields other than store/encode/decode them. In the future we may indicate what values (i.e. what schema dialects) are supported by OpenAPIKit but for now we will not change the behavior of OpenAPIKit in response to the dialect specified.

Work on types in the OpenAPIKit (not OpenAPIKit30) module.

@mattpolzin mattpolzin added the v3.x label Mar 7, 2021
@mattpolzin mattpolzin added the good first issue Good for newcomers label Dec 19, 2021
ayushshrivastv added a commit to ayushshrivastv/OpenAPIKit that referenced this issue Mar 11, 2025
Add support for specifying JSON Schema dialects at both document root and schema levels.
This allows OpenAPI documents to declare which JSON Schema dialect they use via the
 keyword.

Add jsonSchemaDialect property to Document struct
Add schemaDialect property to JSONSchema.CoreContext
Add  coding key for encoding/decoding

Resolves mattpolzin#202
@ziad-ashraf7
Copy link

Hi @mattpolzin , just wondering if its possible to work on an issue and submit the PR without asking to assign?

@mattpolzin
Copy link
Owner Author

@ziad-ashraf7, sure. It’s not a rule that you must have an issue assigned, but I do suggest commenting on the issue in question just to mention you are poking at it and that way someone else doesn’t do the same work at the same time. You can choose to poke at an issue without even commenting though.

ayushshrivastv added a commit to ayushshrivastv/OpenAPIKit that referenced this issue Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants