Skip to content

Fix #213 #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

Fix #213 #564

merged 1 commit into from
May 24, 2018

Conversation

gjrtimmer
Copy link
Collaborator

ADD: SQLITE_ENABLE_UPDATE_DELETE_LIMIT

Fixes: #213

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage remained the same at 68.061% when pulling 79bf9ba on GJRTimmer:fix/213 into a72efd6 on mattn:master.

@mattn mattn merged commit 323a32b into mattn:master May 24, 2018
@mattn
Copy link
Owner

mattn commented May 24, 2018

Thank you

@EmpireJones
Copy link

I'm trying to interpret this comment:
#215 (comment)

note that not mean that this enabling delete limit also when using libsqlite3 on system always.

Am I understanding correctly that this feature is only available with usage of a separate build of libsqlite3, and not the "linux" tag build, as that one uses the 'amalgamation'?

@mholt
Copy link

mholt commented Jan 10, 2019

How does one use this change? I get near "LIMIT": syntax error on the DELETE statement used in the test case.

@rittneje
Copy link
Collaborator

https://www.sqlite.org/compile.html#enable_update_delete_limit

"If this option is defined, then it must also be defined when using the Lemon parser generator tool to generate a parse.c file. Because of this, this option may only be used when the library is built from source, not from the amalgamation or from the collection of pre-packaged C files provided for non-Unix like platforms on the website."

Just adding the compile-time option is not sufficient. You would need a custom amalgamation.

@mholt
Copy link

mholt commented Jan 10, 2019

I see, thank you for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants