MAINT: Sync with upstream changes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in BasicRNG source changes from original author Small doc fixes
|
Should be the last one. |
|
@bashtage There are many documentation build warnings in bashtage/randomgen about the footnotes. Apparently they are never actually referenced. |
|
I think the references are in the same format as in the mtrand module in
released Numpy. Are these problems?
…On Tue, Apr 2, 2019, 19:28 Matti Picus ***@***.***> wrote:
@bashtage <https://github.com/bashtage> There are many documentation
build warnings in bashtage/randomgen about the footnotes. Apparently they
are never actually referenced.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFU5Rbrc5sc-AXg32bWmTlBRZpbN078qks5vc6FcgaJpZM4cYulx>
.
|
|
See these warnings in bashtage/randomgen builds |
|
Yes, I just ignore those. I assume that NumPy's doc system is happy to ignore these too (or doesn't create them in the first place), since there are many examples that are identical, https://github.com/numpy/numpy/blob/master/numpy/random/mtrand/mtrand.pyx#L1797 |
|
It is possible numpydoc fixes these. I use napoleon in randomgen. |
|
Switching to numpydoc (in bashtage/randomgen) is worse: it now emits many warnings of the form This is the diff (requires pip install numpydoc) |
|
Seems to generate a ton of warnings but also works. |
|
I built both and diffed the html. Indeed the differences are only the docstring results. |
mattip
pushed a commit
that referenced
this pull request
Nov 19, 2021
commit 9c833bed5879d77e625556260690c349de18b433 Author: Thomas Li <[email protected]> Date: Wed Nov 17 16:21:27 2021 -0800 Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Update cibw_test_command.sh commit 4bd12df Author: Thomas Li <[email protected]> Date: Mon Nov 15 17:28:47 2021 -0800 # This is a combination of 14 commits. # This is the 1st commit message: Add Windows config to GHA # This is the commit message #2: update script [wheel build] # This is the commit message #3: typo [wheel build] # This is the commit message #4: fix typo? [wheel build] # This is the commit message #5: fix linux builds? [wheel build] # This is the commit message #6: typo [wheel build] # This is the commit message #7: add license and pin to windows 2016 # This is the commit message #8: skip tests [wheel build] # This is the commit message #9: pin to windows 2019 instead [wheel build] # This is the commit message #10: try to find out the error on windows [wheel build] # This is the commit message #11: maybe fix? [wheel build] # This is the commit message #12: maybe fix? [wheel build] # This is the commit message #13: fix? [wheel build] # This is the commit message #14: cleanup [wheel build]
mattip
pushed a commit
that referenced
this pull request
Nov 15, 2023
…n that is not needed by the game of life example Merge ss/hpy-scalar-types to labs-hpy-port * commit '7ff906885dd929a6f33443aaad81ada3fed61f1e': Convert scalar types, comment out some initialization that is not needed by the game of life example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in BasicRNG source changes from original author
Small doc fixes