Reduce default third party invite rate limit to 216 invites per day (#14487)

squahtx · H-Shay · commit ecb7b0502beb · 2022-12-13T13:13:12.000-08:00
The previous default was the same as the `rc_message` rate limit, which
defaults to 17,280 per day.

Signed-off-by: Sean Quah &lt;seanq@matrix.org&gt;
diff --git a/changelog.d/14487.misc b/changelog.d/14487.misc
@@ -0,0 +1 @@
+Reduce default third party invite rate limit to 216 invites per day.
diff --git a/synapse/config/ratelimiting.py b/synapse/config/ratelimiting.py
@@ -150,8 +150,5 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:
 
         self.rc_third_party_invite = RatelimitSettings(
             config.get("rc_third_party_invite", {}),
-            defaults={
-                "per_second": self.rc_message.per_second,
-                "burst_count": self.rc_message.burst_count,
-            },
+            defaults={"per_second": 0.0025, "burst_count": 5},
         )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Reduce default third party invite rate limit to 216 invites per day.`
Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,5 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:`
`150`	`150`
`151`	`151`	`self.rc_third_party_invite = RatelimitSettings(`
`152`	`152`	`config.get("rc_third_party_invite", {}),`
`153`		`- defaults={`
`154`		`- "per_second": self.rc_message.per_second,`
`155`		`- "burst_count": self.rc_message.burst_count,`
`156`		`- },`
	`153`	`+ defaults={"per_second": 0.0025, "burst_count": 5},`
`157`	`154`	`)`