Improve the error code when trying to register using a name reserved for guests.

clokep · clokep · commit 46f8ef1c75de · 2020-08-20T07:20:04.000-04:00
diff --git a/changelog.d/8135.bugfix b/changelog.d/8135.bugfix
@@ -0,0 +1 @@
+Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0.
diff --git a/synapse/handlers/register.py b/synapse/handlers/register.py
@@ -124,7 +124,9 @@ async def check_username(
             try:
                 int(localpart)
                 raise SynapseError(
-                    400, "Numeric user IDs are reserved for guest users."
+                    400,
+                    "Numeric user IDs are reserved for guest users.",
+                    errcode=Codes.INVALID_USERNAME,
                 )
             except ValueError:
                 pass

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0.`