Skip to content

Commit 6b02e39

Browse files
authored
Move .m.rule.roomnotif before .m.rule.tombstone (#1421)
See #1406 for the reasoning on this. TL;DR: the spec has always been wrong here.
1 parent ad94985 commit 6b02e39

File tree

2 files changed

+32
-31
lines changed

2 files changed

+32
-31
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Correct the order of the default override pushrules in the spec.

content/client-server-api/modules/push.md

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -524,29 +524,27 @@ Definition:
524524
}
525525
```
526526

527-
**<a name="mruletombstone"></a>`.m.rule.tombstone`**
527+
**`.m.rule.roomnotif`**
528528

529-
Matches any state event whose type is `m.room.tombstone`. This is
530-
intended to notify users of a room when it is upgraded, similar to what
531-
an `@room` notification would accomplish.
529+
Matches any message whose content is unencrypted and contains the text
530+
`@room`, signifying the whole room should be notified of the event.
532531

533532
Definition:
534533

535534
```json
536535
{
537-
"rule_id": ".m.rule.tombstone",
536+
"rule_id": ".m.rule.roomnotif",
538537
"default": true,
539538
"enabled": true,
540539
"conditions": [
541540
{
542541
"kind": "event_match",
543-
"key": "type",
544-
"pattern": "m.room.tombstone"
542+
"key": "content.body",
543+
"pattern": "@room"
545544
},
546545
{
547-
"kind": "event_match",
548-
"key": "state_key",
549-
"pattern": ""
546+
"kind": "sender_notification_permission",
547+
"key": "room"
550548
}
551549
],
552550
"actions": [
@@ -558,64 +556,66 @@ Definition:
558556
}
559557
```
560558

561-
**`.m.rule.room.server_acl`**
562-
563-
{{% added-in v="1.4" %}}
559+
**<a name="mruletombstone"></a>`.m.rule.tombstone`**
564560

565-
Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events.
561+
Matches any state event whose type is `m.room.tombstone`. This is
562+
intended to notify users of a room when it is upgraded, similar to what
563+
an `@room` notification would accomplish.
566564

567565
Definition:
568566

569567
```json
570568
{
571-
"rule_id": ".m.rule.room.server_acl",
569+
"rule_id": ".m.rule.tombstone",
572570
"default": true,
573571
"enabled": true,
574572
"conditions": [
575573
{
576574
"kind": "event_match",
577575
"key": "type",
578-
"pattern": "m.room.server_acl"
576+
"pattern": "m.room.tombstone"
579577
},
580578
{
581579
"kind": "event_match",
582580
"key": "state_key",
583581
"pattern": ""
584582
}
585583
],
586-
"actions": []
584+
"actions": [
585+
"notify",
586+
{
587+
"set_tweak": "highlight"
588+
}
589+
]
587590
}
588591
```
589592

590-
**`.m.rule.roomnotif`**
593+
**`.m.rule.room.server_acl`**
591594

592-
Matches any message whose content is unencrypted and contains the text
593-
`@room`, signifying the whole room should be notified of the event.
595+
{{% added-in v="1.4" %}}
596+
597+
Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events.
594598

595599
Definition:
596600

597601
```json
598602
{
599-
"rule_id": ".m.rule.roomnotif",
603+
"rule_id": ".m.rule.room.server_acl",
600604
"default": true,
601605
"enabled": true,
602606
"conditions": [
603607
{
604608
"kind": "event_match",
605-
"key": "content.body",
606-
"pattern": "@room"
609+
"key": "type",
610+
"pattern": "m.room.server_acl"
607611
},
608612
{
609-
"kind": "sender_notification_permission",
610-
"key": "room"
613+
"kind": "event_match",
614+
"key": "state_key",
615+
"pattern": ""
611616
}
612617
],
613-
"actions": [
614-
"notify",
615-
{
616-
"set_tweak": "highlight"
617-
}
618-
]
618+
"actions": []
619619
}
620620
```
621621

0 commit comments

Comments
 (0)