Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit b91f0ed

Browse files
authored
Improve partial translation or to have usage context (#9244)
1 parent 9f5857d commit b91f0ed

File tree

5 files changed

+26
-6
lines changed

5 files changed

+26
-6
lines changed

src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,10 @@ export default class CreateSecretStorageDialog extends React.PureComponent<IProp
725725
>
726726
{ _t("Download") }
727727
</AccessibleButton>
728-
<span>{ _t("or") }</span>
728+
<span>{ _t("%(downloadButton)s or %(copyButton)s", {
729+
downloadButton: "",
730+
copyButton: "",
731+
}) }</span>
729732
<AccessibleButton
730733
kind='primary'
731734
className="mx_Dialog_primary mx_CreateSecretStorageDialog_recoveryKeyButtons_copyBtn"

src/components/views/dialogs/AppDownloadDialog.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,10 @@ export const AppDownloadDialog: FC<IDialogProps> = ({ onFinished }: IDialogProps
6969
{ _t("iOS") }
7070
</Heading>
7171
<QRCode data={urlAppStore} margin={0} width={172} />
72-
<div className="mx_AppDownloadDialog_info">or</div>
72+
<div className="mx_AppDownloadDialog_info">{ _t("%(qrCode)s or %(appLinks)s", {
73+
appLinks: "",
74+
qrCode: "",
75+
}) }</div>
7376
<div className="mx_AppDownloadDialog_links">
7477
<AccessibleButton
7578
element="a"
@@ -86,7 +89,10 @@ export const AppDownloadDialog: FC<IDialogProps> = ({ onFinished }: IDialogProps
8689
{ _t("Android") }
8790
</Heading>
8891
<QRCode data={urlAndroid} margin={0} width={172} />
89-
<div className="mx_AppDownloadDialog_info">or</div>
92+
<div className="mx_AppDownloadDialog_info">{ _t("%(qrCode)s or %(appLinks)s", {
93+
appLinks: "",
94+
qrCode: "",
95+
}) }</div>
9096
<div className="mx_AppDownloadDialog_links">
9197
<AccessibleButton
9298
element="a"

src/components/views/dialogs/security/AccessSecretStorageDialog.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,10 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
395395
/>
396396
</div>
397397
<span className="mx_AccessSecretStorageDialog_recoveryKeyEntry_entryControlSeparatorText">
398-
{ _t("or") }
398+
{ _t("%(securityKey)s or %(recoveryFile)s", {
399+
recoveryFile: "",
400+
securityKey: "",
401+
}) }
399402
</span>
400403
<div>
401404
<input type="file"

src/components/views/right_panel/VerificationPanel.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,12 @@ export default class VerificationPanel extends React.PureComponent<IProps, IStat
100100
</div>;
101101
}
102102
const or = qrBlockDialog && sasBlockDialog ?
103-
<div className='mx_VerificationPanel_QRPhase_betweenText'>{ _t("or") }</div> : null;
103+
<div className='mx_VerificationPanel_QRPhase_betweenText'>
104+
{ _t("%(qrCode)s or %(emojiCompare)s", {
105+
emojiCompare: "",
106+
qrCode: "",
107+
}) }
108+
</div> : null;
104109
return (
105110
<div>
106111
{ _t("Verify this device by completing one of the following:") }

src/i18n/strings/en_EN.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2135,7 +2135,7 @@
21352135
"Compare unique emoji": "Compare unique emoji",
21362136
"Compare a unique set of emoji if you don't have a camera on either device": "Compare a unique set of emoji if you don't have a camera on either device",
21372137
"Start": "Start",
2138-
"or": "or",
2138+
"%(qrCode)s or %(emojiCompare)s": "%(qrCode)s or %(emojiCompare)s",
21392139
"Verify this device by completing one of the following:": "Verify this device by completing one of the following:",
21402140
"Verify by scanning": "Verify by scanning",
21412141
"Ask %(displayName)s to scan your code:": "Ask %(displayName)s to scan your code:",
@@ -2506,6 +2506,7 @@
25062506
"You can turn this off anytime in settings": "You can turn this off anytime in settings",
25072507
"Download %(brand)s Desktop": "Download %(brand)s Desktop",
25082508
"iOS": "iOS",
2509+
"%(qrCode)s or %(appLinks)s": "%(qrCode)s or %(appLinks)s",
25092510
"Download on the App Store": "Download on the App Store",
25102511
"Android": "Android",
25112512
"Get it on Google Play": "Get it on Google Play",
@@ -2938,6 +2939,7 @@
29382939
"Enter your Security Phrase or <button>use your Security Key</button> to continue.": "Enter your Security Phrase or <button>use your Security Key</button> to continue.",
29392940
"Security Key": "Security Key",
29402941
"Use your Security Key to continue.": "Use your Security Key to continue.",
2942+
"%(securityKey)s or %(recoveryFile)s": "%(securityKey)s or %(recoveryFile)s",
29412943
"Destroy cross-signing keys?": "Destroy cross-signing keys?",
29422944
"Deleting cross-signing keys is permanent. Anyone you have verified with will see security alerts. You almost certainly don't want to do this, unless you've lost every device you can cross-sign from.": "Deleting cross-signing keys is permanent. Anyone you have verified with will see security alerts. You almost certainly don't want to do this, unless you've lost every device you can cross-sign from.",
29432945
"Clear cross-signing keys": "Clear cross-signing keys",
@@ -3420,6 +3422,7 @@
34203422
"Upgrade this session to allow it to verify other sessions, granting them access to encrypted messages and marking them as trusted for other users.": "Upgrade this session to allow it to verify other sessions, granting them access to encrypted messages and marking them as trusted for other users.",
34213423
"Enter a security phrase only you know, as it's used to safeguard your data. To be secure, you shouldn't re-use your account password.": "Enter a security phrase only you know, as it's used to safeguard your data. To be secure, you shouldn't re-use your account password.",
34223424
"Store your Security Key somewhere safe, like a password manager or a safe, as it's used to safeguard your encrypted data.": "Store your Security Key somewhere safe, like a password manager or a safe, as it's used to safeguard your encrypted data.",
3425+
"%(downloadButton)s or %(copyButton)s": "%(downloadButton)s or %(copyButton)s",
34233426
"Unable to query secret storage status": "Unable to query secret storage status",
34243427
"If you cancel now, you may lose encrypted messages & data if you lose access to your logins.": "If you cancel now, you may lose encrypted messages & data if you lose access to your logins.",
34253428
"You can also set up Secure Backup & manage your keys in Settings.": "You can also set up Secure Backup & manage your keys in Settings.",

0 commit comments

Comments
 (0)