Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 8f7afc1

Browse files
committed
use null vars for context menu lists
1 parent d5bfc51 commit 8f7afc1

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/components/views/context_menus/MessageContextMenu.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ export default class MessageContextMenu extends React.Component {
257257
let externalURLButton;
258258
let quoteButton;
259259
let collapseReplyThread;
260-
const optionLists = [];
260+
let redactItemList;
261261

262262
// status is SENT before remote-echo, null after
263263
const isSent = !eventStatus || eventStatus === EventStatus.SENT;
@@ -388,7 +388,7 @@ export default class MessageContextMenu extends React.Component {
388388
);
389389
}
390390

391-
optionLists.push((
391+
const commonItemsList = (
392392
<IconizedContextMenuOptionList key={'group1'}>
393393
{ quoteButton }
394394
{ forwardButton }
@@ -401,14 +401,14 @@ export default class MessageContextMenu extends React.Component {
401401
{ resendReactionsButton }
402402
{ collapseReplyThread }
403403
</IconizedContextMenuOptionList>
404-
));
404+
);
405405

406406
if (redactButton) {
407-
optionLists.push((
407+
redactItemList = (
408408
<IconizedContextMenuOptionList key={'group2'} red>
409409
{ redactButton }
410410
</IconizedContextMenuOptionList>
411-
));
411+
);
412412
}
413413

414414
return (
@@ -417,7 +417,8 @@ export default class MessageContextMenu extends React.Component {
417417
className="mx_MessageContextMenu"
418418
compact={true}
419419
>
420-
{ optionLists }
420+
{ commonItemsList }
421+
{ redactItemList }
421422
</IconizedContextMenu>
422423
);
423424
}

0 commit comments

Comments
 (0)