Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange (#7053)

bradtgmurray · turt2live · web-flow · commit 74376f989e8d · 2021-11-02T20:44:54.000Z
* Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange

* Update src/stores/room-list/algorithms/Algorithm.ts

Co-authored-by: Travis Ralston &lt;travpc@gmail.com&gt;

Co-authored-by: Travis Ralston &lt;travpc@gmail.com&gt;
Co-authored-by: Travis Ralston &lt;travisr@matrix.org&gt;
diff --git a/src/stores/room-list/algorithms/Algorithm.ts b/src/stores/room-list/algorithms/Algorithm.ts
@@ -722,7 +722,8 @@ export class Algorithm extends EventEmitter {
                 cause = RoomUpdateCause.Timeline;
                 didTagChange = true;
             } else {
-                cause = RoomUpdateCause.Timeline;
+                // This is a tag change update and no tags were changed, nothing to do!
+                return false;
             }
 
             if (didTagChange && isSticky) {

Original file line number	Diff line number	Diff line change
`@@ -722,7 +722,8 @@ export class Algorithm extends EventEmitter {`
`722`	`722`	`cause = RoomUpdateCause.Timeline;`
`723`	`723`	`didTagChange = true;`
`724`	`724`	`} else {`
`725`		`- cause = RoomUpdateCause.Timeline;`
	`725`	`+ // This is a tag change update and no tags were changed, nothing to do!`
	`726`	`+ return false;`
`726`	`727`	`}`
`727`	`728`
`728`	`729`	`if (didTagChange && isSticky) {`