Add test coverage (#9928)

Author: weeman1337

src/stores/widgets/WidgetLayoutStore.ts

@@ -414,7 +414,7 @@ export class WidgetLayoutStore extends ReadyWatchingStore {
         widgets.forEach((w, i) => {
             localLayout[w.id] = {
                 container: container,
-                width: widths[i],
+                width: widths?.[i],
                 index: i,
                 height: height,
             };
@@ -437,7 +437,7 @@ export class WidgetLayoutStore extends ReadyWatchingStore {
         widgets.forEach((w, i) => {
             localLayout[w.id] = {
                 container: container,
-                width: widths[i],
+                width: widths?.[i],
                 index: i,
                 height: height,
             };

test/settings/handlers/RoomDeviceSettingsHandler-test.ts

@@ -15,21 +15,49 @@ limitations under the License.
 */
 
 import RoomDeviceSettingsHandler from "../../../src/settings/handlers/RoomDeviceSettingsHandler";
-import { WatchManager } from "../../../src/settings/WatchManager";
+import { SettingLevel } from "../../../src/settings/SettingLevel";
+import { CallbackFn, WatchManager } from "../../../src/settings/WatchManager";
 
 describe("RoomDeviceSettingsHandler", () => {
-    it("should correctly read cached values", () => {
-        const watchers = new WatchManager();
-        const handler = new RoomDeviceSettingsHandler(watchers);
-
-        const settingName = "RightPanel.phases";
-        const roomId = "!room:server";
-        const value = {
-            isOpen: true,
-            history: [{}],
-        };
-
-        handler.setValue(settingName, roomId, value);
-        expect(handler.getValue(settingName, roomId)).toEqual(value);
+    const roomId = "!room:example.com";
+    const value = "test value";
+    const testSettings = [
+        "RightPanel.phases",
+        // special case in RoomDeviceSettingsHandler
+        "blacklistUnverifiedDevices",
+    ];
+    let watchers: WatchManager;
+    let handler: RoomDeviceSettingsHandler;
+    let settingListener: CallbackFn;
+
+    beforeEach(() => {
+        watchers = new WatchManager();
+        handler = new RoomDeviceSettingsHandler(watchers);
+        settingListener = jest.fn();
+    });
+
+    afterEach(() => {
+        watchers.unwatchSetting(settingListener);
+    });
+
+    it.each(testSettings)("should write/read/clear the value for »%s«", (setting: string): void => {
+        // initial value should be null
+        watchers.watchSetting(setting, roomId, settingListener);
+
+        expect(handler.getValue(setting, roomId)).toBeNull();
+
+        // set and read value
+        handler.setValue(setting, roomId, value);
+        expect(settingListener).toHaveBeenCalledWith(roomId, SettingLevel.ROOM_DEVICE, value);
+        expect(handler.getValue(setting, roomId)).toEqual(value);
+
+        // clear value
+        handler.setValue(setting, roomId, null);
+        expect(settingListener).toHaveBeenCalledWith(roomId, SettingLevel.ROOM_DEVICE, null);
+        expect(handler.getValue(setting, roomId)).toBeNull();
+    });
+
+    it("canSetValue should return true", () => {
+        expect(handler.canSetValue("test setting", roomId)).toBe(true);
     });
 });

test/stores/AutoRageshakeStore-test.ts

@@ -0,0 +1,100 @@
+/*
+Copyright 2023 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import { mocked } from "jest-mock";
+import { ClientEvent, EventType, MatrixClient, MatrixEvent, MatrixEventEvent } from "matrix-js-sdk/src/matrix";
+import { SyncState } from "matrix-js-sdk/src/sync";
+
+import SettingsStore from "../../src/settings/SettingsStore";
+import AutoRageshakeStore from "../../src/stores/AutoRageshakeStore";
+import { mkEvent, stubClient } from "../test-utils";
+
+jest.mock("../../src/rageshake/submit-rageshake");
+
+describe("AutoRageshakeStore", () => {
+    const roomId = "!room:example.com";
+    let client: MatrixClient;
+    let utdEvent: MatrixEvent;
+    let autoRageshakeStore: AutoRageshakeStore;
+
+    beforeAll(() => {
+        jest.useFakeTimers();
+    });
+
+    afterAll(() => {
+        jest.useRealTimers();
+    });
+
+    beforeEach(() => {
+        jest.spyOn(SettingsStore, "getValue").mockReturnValue(true);
+
+        client = stubClient();
+
+        // @ts-ignore bypass private ctor for tests
+        autoRageshakeStore = new AutoRageshakeStore();
+        autoRageshakeStore.start();
+
+        utdEvent = mkEvent({
+            event: true,
+            content: {},
+            room: roomId,
+            user: client.getSafeUserId(),
+            type: EventType.RoomMessage,
+        });
+        jest.spyOn(utdEvent, "isDecryptionFailure").mockReturnValue(true);
+    });
+
+    afterEach(() => {
+        jest.restoreAllMocks();
+    });
+
+    describe("when the initial sync completed", () => {
+        beforeEach(() => {
+            client.emit(ClientEvent.Sync, SyncState.Syncing, SyncState.Stopped, { nextSyncToken: "abc123" });
+        });
+
+        describe("and an undecryptable event occurs", () => {
+            beforeEach(() => {
+                client.emit(MatrixEventEvent.Decrypted, utdEvent);
+                // simulate event grace period
+                jest.advanceTimersByTime(5500);
+            });
+
+            it("should send a rageshake", () => {
+                expect(mocked(client).sendToDevice.mock.calls).toMatchInlineSnapshot(`
+                    [
+                      [
+                        "im.vector.auto_rs_request",
+                        {
+                          "@userId:matrix.org": {
+                            "undefined": {
+                              "device_id": undefined,
+                              "event_id": "${utdEvent.getId()}",
+                              "recipient_rageshake": undefined,
+                              "room_id": "!room:example.com",
+                              "sender_key": undefined,
+                              "session_id": undefined,
+                              "user_id": "@userId:matrix.org",
+                            },
+                          },
+                        },
+                      ],
+                    ]
+                `);
+            });
+        });
+    });
+});