Remove "Add Space" button from RoomListHeader when user cannot create spaces (#9129)

* Remove Add Space button in RoomListHeader when user cannot createSpaces

* Reuse the same booleans as SpaceContextMenu

* Code review fixes

* Fix test for standard case

* Refactor tests and add more

* Test the PlusMenu, where the bug originally was

* Add tests for plus menu

* Refactor tests

* add type in functions and use DMRoomMap#setShared

* use of wrapInMatrixClientContext

* Trigger CI

* Ignore enzyme deprecation in RoomListHeader-test.tsx

Co-authored-by: Estelle Comment <[email protected]>
Co-authored-by: mcalinghee <[email protected]>
Co-authored-by: Michael Weimann <[email protected]>

Author: 4 people

src/components/views/rooms/RoomListHeader.tsx

@@ -146,15 +146,19 @@ const RoomListHeader = ({ onVisibilityChange }: IProps) => {
         }
     }, [onVisibilityChange]);
 
-    const canAddRooms = activeSpace?.currentState?.maySendStateEvent(EventType.SpaceChild, cli.getUserId());
-
-    const canCreateRooms = shouldShowComponent(UIComponent.CreateRooms);
     const canExploreRooms = shouldShowComponent(UIComponent.ExploreRooms);
+    const canCreateRooms = shouldShowComponent(UIComponent.CreateRooms);
+    const canCreateSpaces = shouldShowComponent(UIComponent.CreateSpaces);
+
+    const hasPermissionToAddSpaceChild =
+        activeSpace?.currentState?.maySendStateEvent(EventType.SpaceChild, cli.getUserId());
+    const canAddSubRooms = hasPermissionToAddSpaceChild && canCreateRooms;
+    const canAddSubSpaces = hasPermissionToAddSpaceChild && canCreateSpaces;
 
     // If the user can't do anything on the plus menu, don't show it. This aims to target the
     // plus menu shown on the Home tab primarily: the user has options to use the menu for
     // communities and spaces, but is at risk of no options on the Home tab.
-    const canShowPlusMenu = canCreateRooms || canExploreRooms || activeSpace;
+    const canShowPlusMenu = canCreateRooms || canExploreRooms || canCreateSpaces || activeSpace;
 
     let contextMenu: JSX.Element;
     if (mainMenuDisplayed && mainMenuHandle.current) {
@@ -249,10 +253,10 @@ const RoomListHeader = ({ onVisibilityChange }: IProps) => {
                         showAddExistingRooms(activeSpace);
                         closePlusMenu();
                     }}
-                    disabled={!canAddRooms}
-                    tooltip={!canAddRooms && _t("You do not have permissions to add rooms to this space")}
+                    disabled={!canAddSubRooms}
+                    tooltip={!canAddSubRooms && _t("You do not have permissions to add rooms to this space")}
                 />
-                <IconizedContextMenuOption
+                { canCreateSpaces && <IconizedContextMenuOption
                     label={_t("Add space")}
                     iconClassName="mx_RoomListHeader_iconPlus"
                     onClick={(e) => {
@@ -261,11 +265,12 @@ const RoomListHeader = ({ onVisibilityChange }: IProps) => {
                         showCreateNewSubspace(activeSpace);
                         closePlusMenu();
                     }}
-                    disabled={!canAddRooms}
-                    tooltip={!canAddRooms && _t("You do not have permissions to add spaces to this space")}
+                    disabled={!canAddSubSpaces}
+                    tooltip={!canAddSubSpaces && _t("You do not have permissions to add spaces to this space")}
                 >
                     <BetaPill />
                 </IconizedContextMenuOption>
+                }
             </IconizedContextMenuOptionList>
         </IconizedContextMenu>;
     } else if (plusMenuDisplayed) {