Skip to content

Commit 8341d9c

Browse files
committed
make sonar cube happy (it does not know about the type constraints...)
Signed-off-by: Timo K <[email protected]>
1 parent 25f4d6f commit 8341d9c

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

src/matrixrtc/CallMembership.ts

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ export class CallMembership {
253253
switch (kind) {
254254
case "rtc":
255255
return data.member.user_id;
256-
case "session":
256+
default: // "session":
257257
return this.parentEventData.sender;
258258
}
259259
}
@@ -271,7 +271,7 @@ export class CallMembership {
271271
switch (kind) {
272272
case "rtc":
273273
return data.slot_id;
274-
case "session":
274+
default: // "session":
275275
return slotDescriptionToId({ application: this.application, id: data.call_id });
276276
}
277277
}
@@ -281,7 +281,7 @@ export class CallMembership {
281281
switch (kind) {
282282
case "rtc":
283283
return data.member.device_id;
284-
case "session":
284+
default: // "session":
285285
return data.device_id;
286286
}
287287
}
@@ -302,7 +302,7 @@ export class CallMembership {
302302
switch (kind) {
303303
case "rtc":
304304
return data.application.type;
305-
case "session":
305+
default: // "session":
306306
return data.application;
307307
}
308308
}
@@ -311,7 +311,7 @@ export class CallMembership {
311311
switch (kind) {
312312
case "rtc":
313313
return data.application;
314-
case "session":
314+
default: // "session":
315315
return { "type": data.application, "m.call.intent": data["m.call.intent"] };
316316
}
317317
}
@@ -322,10 +322,8 @@ export class CallMembership {
322322
switch (kind) {
323323
case "rtc":
324324
return undefined;
325-
case "session":
325+
default: // "session":
326326
return data.scope;
327-
default:
328-
return undefined;
329327
}
330328
}
331329

@@ -337,7 +335,7 @@ export class CallMembership {
337335
switch (kind) {
338336
case "rtc":
339337
return data.member.id;
340-
case "session":
338+
default: // "session":
341339
return (this.createdTs() ?? "").toString();
342340
}
343341
}
@@ -348,7 +346,7 @@ export class CallMembership {
348346
case "rtc":
349347
// TODO we need to read the referenced (relation) event if available to get the real created_ts
350348
return this.parentEvent.getTs();
351-
case "session":
349+
default: // "session":
352350
return data.created_ts ?? this.parentEvent.getTs();
353351
}
354352
}
@@ -362,7 +360,7 @@ export class CallMembership {
362360
switch (kind) {
363361
case "rtc":
364362
return undefined;
365-
case "session":
363+
default: // "session":
366364
// TODO: calculate this from the MatrixRTCSession join configuration directly
367365
return this.createdTs() + (data.expires ?? DEFAULT_EXPIRE_DURATION);
368366
}
@@ -376,7 +374,7 @@ export class CallMembership {
376374
switch (kind) {
377375
case "rtc":
378376
return undefined;
379-
case "session":
377+
default: // "session":
380378
// Assume that local clock is sufficiently in sync with other clocks in the distributed system.
381379
// We used to try and adjust for the local clock being skewed, but there are cases where this is not accurate.
382380
// The current implementation allows for the local clock to be -infinity to +MatrixRTCSession.MEMBERSHIP_EXPIRY_TIME/2
@@ -392,7 +390,7 @@ export class CallMembership {
392390
switch (kind) {
393391
case "rtc":
394392
return false;
395-
case "session":
393+
default: // "session":
396394
return this.getMsUntilExpiry()! <= 0;
397395
}
398396
}
@@ -407,7 +405,7 @@ export class CallMembership {
407405
switch (kind) {
408406
case "rtc":
409407
return data.rtc_transports[0];
410-
case "session":
408+
default: // "session":
411409
switch (data.focus_active.focus_selection) {
412410
case "oldest_membership":
413411
if (CallMembership.equal(this, oldestMembership)) return data.foci_preferred[0];
@@ -423,7 +421,7 @@ export class CallMembership {
423421
switch (kind) {
424422
case "rtc":
425423
return data.rtc_transports;
426-
case "session":
424+
default: // "session":
427425
return data.foci_preferred;
428426
}
429427
}

0 commit comments

Comments
 (0)