Skip to content

Commit 24710ee

Browse files
authored
Add a basic PR checklist for all PRs (#2511)
It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things. Note that signoff is not required for core developers.
1 parent 1fbfdaf commit 24710ee

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1-
<!-- Please read https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md before submitting your pull request -->
1+
<!-- Thanks for submitting a PR! Please ensure the following requirements are met in order for us to review your PR -->
22

3-
<!-- Include a Sign-Off as described in https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off -->
3+
## Checklist
44

5-
<!-- To specify text for the changelog entry (otherwise the PR title will be used):
6-
Notes:
5+
* [ ] Tests written for new code (and old code if feasible)
6+
* [ ] Linter and other CI checks pass
7+
* [ ] Sign-off given on the changes (see [CONTRIBUTING.md](https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md))
8+
9+
<!--
10+
If you would like to specify text for the changelog entry other than your PR title, add the following:
11+
12+
Notes: Add super cool feature
713
-->

0 commit comments

Comments
 (0)