Skip to content

Tidy up scatter code #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2022
Merged

Tidy up scatter code #47

merged 2 commits into from
May 19, 2022

Conversation

dstansby
Copy link
Member

This is some misc tidying to the scatter code:

  • Use Optional instead of Union[None, ...] in typing
  • Remove a redundant __init__()
  • Always add the selection GUI to the property scatter (we can change to make this optional later, but for now I think keeping code simpler is better)

@kevinyamauchi could you take a look at this and see if it all looks okay?

Copy link
Contributor

@kevinyamauchi kevinyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes make sense to me! See my comment above for a fix for the update function. Happy to discuss further!

@dstansby dstansby added this to the 0.2.0 milestone May 19, 2022
@dstansby dstansby merged commit e47ff04 into main May 19, 2022
@dstansby dstansby deleted the scatter-tidy branch May 19, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants