Skip to content

Make widget compliant with napari color scheme #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jo-mueller
Copy link
Contributor

Fixes #1

Hi @dstansby ,

I made some changes to the style of the plot widget. Not really by introducing a style sheet (I'm not sure whether that concept applies to canvas/axes objects) but just by creating a ax instance with changed spine/tick/background parameters.

Let me know what you think :)

  • passes tests

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #26 (010a0fc) into main (2f5e92a) will increase coverage by 0.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   89.69%   90.56%   +0.87%     
==========================================
  Files           7        7              
  Lines          97      106       +9     
==========================================
+ Hits           87       96       +9     
  Misses         10       10              
Impacted Files Coverage Δ
src/napari_matplotlib/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5e92a...010a0fc. Read the comment docs.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot! I have some suggested improvements in mind, but I'll put those in a new issue since I don't want to block this improvement

@dstansby dstansby merged commit 3d970a1 into matplotlib:main May 5, 2022
@jo-mueller jo-mueller deleted the make-widget-compliant-with-napari-color-scheme branch May 6, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom "napari-like" style sheet
4 participants