Add precision in README about show_nontrading
behavior
#397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the case with a row with
NaN
values, butshow_nontrading=False
would not remove the intervals corresponding toNaN
data (and 0 volume).Filtering the data by removing the rows with
NaN
data solves the issue, therefore I believe it is necessary to explain how thisshow_nontrading
behaves, which is not intuitive to me.Thank you!