Refactor caddy configuration #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does mean that you can't run it directly, but it reduces duplication of the list of repos. Closes matplotlib#11
Unfortunately, that is now useless since the Caddyfile does not exist in its final form.
And thus drop the mirroring of the main site to the webhook domain and vice versa. Fixes matplotlib#10
We can't do this in general, but at least can catch any issues before Ansible deploys the expanded configuration.
tacaswell
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Caddyfile to a template that is generated by Ansible. This reduces the duplicate copy of the repos list, adds automatic tls switch based on Ansible vars, and additionally splits the main and webhook domains.
Unfortunately, the downside is that we no longer can run Caddy on an existing Caddyfile locally or run validate in tests, but there may be some local Ansible setup that works for it instead (see #11).
This also updates the TLS certs, as the old test ones had expired.