Skip to content

Refactor caddy configuration #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 29, 2022

This moves the Caddyfile to a template that is generated by Ansible. This reduces the duplicate copy of the repos list, adds automatic tls switch based on Ansible vars, and additionally splits the main and webhook domains.

Unfortunately, the downside is that we no longer can run Caddy on an existing Caddyfile locally or run validate in tests, but there may be some local Ansible setup that works for it instead (see #11).

This also updates the TLS certs, as the old test ones had expired.

QuLogic added 6 commits March 29, 2022 19:06
This does mean that you can't run it directly, but it reduces
duplication of the list of repos.

Closes matplotlib#11
Unfortunately, that is now useless since the Caddyfile does not exist in
its final form.
And thus drop the mirroring of the main site to the webhook domain and
vice versa.

Fixes matplotlib#10
We can't do this in general, but at least can catch any issues before
Ansible deploys the expanded configuration.
@tacaswell tacaswell merged commit 236fd1c into matplotlib:main Mar 30, 2022
@QuLogic QuLogic deleted the refactor-caddy branch March 30, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants