Skip to content

Formatting adjustments #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Formatting adjustments #93

merged 1 commit into from
Nov 18, 2021

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Nov 17, 2021

  • Use color='green' instead of color='C1' for Quick Start. 'C1' is too obscure and colorcycles too much of a concept for the Quick Start.

  • Whitespace: Use PEP-8 whitespace rules in code snippets

  • Remove [explode] from pie() and [cmap] from imshow(): All other functions only list the primary data fields (with the exception of plot(..., [fmt]), but that function is so prominent that I'll make an exception for it).

    The parameters cmap and explode are still listed, so that information is not lost.

- Whitespace
- Remove [explode] from `pie()` and [cmap] from `imshow()`:
  All other functions only list the primary data fields (with the
  exception of `plot(..., [fmt])`, but that function is so prominent
  that I'll make an exception for it.
  The parameters `cmap` and `explode` are still listed, so that
  information is not lost.
@QuLogic
Copy link
Member

QuLogic commented Nov 18, 2021

The 'Cn' notation is mentioned on the same page, in column 3.

@timhoffm
Copy link
Member Author

Yes, but it's better if the first introductory code is simple and self-contained.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good on the built sheet....

@jklymak jklymak merged commit 5f45dcb into matplotlib:master Nov 18, 2021
@timhoffm timhoffm deleted the param-format branch November 18, 2021 20:38
@rougier
Copy link
Member

rougier commented Nov 22, 2021

I would have kept the C1 but it's fine I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants