Add filtering of CSS styles like padding/margin, etc. #1182 and #1183 #1554
Conversation
…, and handle things like padding-top, etc. Resolves issue mathjax#1182
| BBoxStyle: function (styles) {return SAFE.filterStyles(styles)}, | ||
| BBoxPadding: function (pad) { | ||
| var styles = SAFE.filterStyles("padding: "+pad); | ||
| return (styles ? pad : 0); |
There was a problem hiding this comment.
Personally, I prefer these parentheses, and there are a number of places that they are used in this way in the current code base. We can argue about develop a coding style for v3.0, but I don't think it is necessary to switch styles for a few lines of 2.7 when all the other instances are different.
There was a problem hiding this comment.
Fine. NP.
Personally I prefer redundant whitespace to obsolete parentheses for readability....
I believe for v3.0 we just have to agree on a style and mandatory linting!
There was a problem hiding this comment.
I believe for v3.0 we just have to agree on a style and mandatory linting!
And use editorconfig.org and similar tools to minimize inconvenience.
There was a problem hiding this comment.
Personally I prefer redundant whitespace
I personally find excessive white space hard to read. But I know I will have to modify my old stodgy ways. I will try not to argue too much, and am sure I can adapt over time.
padding,margin,border,outline, etc. (Safe extension should allow max/min values for numeric properties like padding #1182)padding-top,padding-right, etc. based onsafeStylessettings forpaddingas well as forpaddingTop, etc.font-sizestyle.\bbox(Safe extension should process the padding value of \bbox #1183)