Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Build Failure on Node 7.1.0 and 8.1.0 #832

Closed
@ClashTheBunny

Description

@ClashTheBunny

What MDC-Web Version are you using?

0.12.1 and 0.13.0

What OS are you using?

macOS El Cap and Debian Jessie 8.8 (cat /etc/debian_version)
macOS El Cap with xcode installed works, macOS without has node-gyp complain about xcode-select (possibly nodejs/node-gyp#569). Both have fully updated nodejs (8.1.0). Not sure about any other differences between them

The Debian Jessie docker container is from: https://github.com/cljsjs/packages/blob/master/Dockerfile

This does the same thing as the mac without xcode for some reason. Both on Node 7.1.0 and Node 8.1.0.

What are the steps to reproduce the bug?

cljsjs uses CircleCI to build all of their packages, and using the docker container that they use, I get build failures. Both with 0.12.1 and 0.13.0. You can see the 0.12.1 issue (cljsjs/packages#1203) as well as this pull request to bump to 0.13.0:
cljsjs/packages#1208

As can be seen in the build logs, both node versions fail:
https://circleci.com/gh/cljsjs/packages/2125 with cljsjs/build-image:0.0.2 (Node 7.10.0) for mdc 0.12.1
and
https://circleci.com/gh/cljsjs/packages/2193 with cljsjs/build-image:0.0.3 (Node 8.1.0) for mdc 0.13.0

But with very similar broken results.

To reproduce,docker run -it cljsjs/build-image:0.0.3 or docker run -it cljsjs/build-image:0.0.2 then clone cljsjs to ~/cljsjs:
git clone https://github.com/cljsjs/packages ~/cljsjs
and checkout my pull request:

cd ~/cljsjs
git fetch --force origin pull/1208/head:remotes/origin/pull/1208
git reset --hard df1d96a3d0b184675f132dfb476304ff4f770395 
and then running the circleci scripts:
./circle.sh

What is the expected behavior?

Builds correctly.

What is the actual behavior?

Doesn't build correctly with various versions of node.

Any other information you believe would be useful?

It results in a 10K build/material-components-web.js vs a successful build on my MacMini of about 400K. No min version is built.

Could this have to do with the version of google closure being used and e21ec90? It doesn't seem like it because it builds fine on a MacMini and not on a MacBook Pro. My guess was that it had to do with #771, but it seems broken for both versions of node tried above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions