feat(text-field): character counter #861

ghost · 2019-05-12T09:49:54Z

related to #817

TODO

codecov-io · 2019-05-12T09:54:35Z

Codecov Report

Merging #861 into rc0.14.0 will increase coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           rc0.14.0     #861      +/-   ##
============================================
+ Coverage     93.99%   94.09%   +0.09%     
============================================
  Files            85       86       +1     
  Lines          3599     3643      +44     
  Branches        568      574       +6     
============================================
+ Hits           3383     3428      +45     
  Misses           90       90              
+ Partials        126      125       -1

Impacted Files	Coverage Δ
packages/menu/MenuListItem.tsx	`100% <ø> (ø)`	⬆️
packages/list/ListItem.tsx	`99.01% <ø> (ø)`	⬆️
packages/text-field/character-counter/index.tsx	`100% <100%> (ø)`
packages/text-field/index.tsx	`98.26% <100%> (+0.78%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a7f41...963d359. Read the comment docs.

moog16

@TroyTae Thanks for taking a stab at the char counter. Could you provide a screenshot test of some sort? Its difficult to follow what is going on without a working example.

googlebot · 2019-05-16T02:16:42Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

…g is textarea

moog16 · 2019-05-16T17:15:59Z

@TroyTae is this ready for review? I checked out code and it failed to compile. Let me know when you're ready. Thanks! :)

ghost · 2019-05-17T06:27:48Z

@moog16
Is there compile error?
Can you show me?
I have no error and unit test is passed.

I need one help.
I don't understand about screenshot test well...
How can I fix screenshot test error?

moog16 · 2019-05-17T20:51:21Z

@TroyTae looks like it is working now!

ghost · 2019-05-30T13:17:45Z

I think there was an error in the merge process.
Now I fix it!

moog16 · 2019-05-31T13:21:17Z

@TroyTae I updated branch to rc0.14.0. Please fix conflicts.

ghost · 2019-05-31T15:48:32Z

@moog16
I fixed it!

moog16 · 2019-06-01T12:41:42Z

@TroyTae can you try creating a new branch from your rc0.13.0 branch and opening a PR? I'm not sure why your branch isn't picking up the changes in the screenshot tests. Possibly some kind of name collision could be happening? I can confirm there is a text-field/characterCounter image, so it shouldn't be be 404'ing.

ghost · 2019-06-01T13:14:31Z

@moog16
First I combined two screenshot test file.
If this error's cause is name conflict, I guess this change can solve them.

test/screenshot/text-field/variants.tsx

moog16 · 2019-06-03T10:24:00Z

signed in #861 (comment)

googlebot · 2019-06-03T10:24:28Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

moog16 · 2019-06-03T10:26:47Z

@TroyTae please run npm run fix and fix all prettier/lint warnings. Then we're good to go!

googlebot · 2019-06-03T10:58:37Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

ghost · 2019-06-03T11:08:47Z

@moog16
I didn’t know about npm run fix.
So I found each one and fixed it 😂
Anyway I fixed it!

moog16 · 2019-06-03T11:13:24Z

Thanks!

codecov-io · 2019-06-03T12:05:51Z

Codecov Report

Merging #861 into rc0.14.0 will increase coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           rc0.14.0     #861      +/-   ##
============================================
+ Coverage     93.99%   94.09%   +0.09%     
============================================
  Files            85       86       +1     
  Lines          3599     3643      +44     
  Branches        568      574       +6     
============================================
+ Hits           3383     3428      +45     
  Misses           90       90              
+ Partials        126      125       -1

Impacted Files	Coverage Δ
packages/menu/MenuListItem.tsx	`100% <ø> (ø)`	⬆️
packages/list/ListItem.tsx	`99.01% <ø> (ø)`	⬆️
packages/text-field/character-counter/index.tsx	`100% <100%> (ø)`
packages/text-field/index.tsx	`98.26% <100%> (+0.78%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a7f41...963d359. Read the comment docs.

googlebot · 2019-06-03T12:05:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

cpboyd and others added 8 commits May 10, 2019 09:38

fix(chips): ClientRect/DOMRect is not IE11 compatible (#855)

c08b2a7

feat(text-field): create character-counter

1d74bdc

feat(text-field): delete state

cf24b80

feat(text-field): use constant

536e233

feat(text-field): render character counter

706e30d

feat(text-field): use inputProps in characterCounterProps

e2d0f4c

feat(text-field): textarea render case

d2e47d0

test(text-field): create unit test

573311e

googlebot added the cla: yes label May 12, 2019

moog16 suggested changes May 13, 2019

View reviewed changes

fix(chips): ClientRect/DOMRect is not IE11 compatible (#855)

8c4c383

moog16 force-pushed the rc0.13.0 branch from c08b2a7 to 8c4c383 Compare May 15, 2019 21:02

lucasecdb and others added 2 commits May 15, 2019 15:42

chore: add prettier (#863)

317c1b3

Merge branch 'rc0.13.0' into rc0.13.0

624f1c8

googlebot added cla: no and removed cla: yes labels May 16, 2019

Troy Tae added 8 commits May 16, 2019 17:45

test(text-field): recover inputProps test

2bba304

test(text-field): Character counter renders in front of input when ta…

99c8897

…g is textarea

test(text-field): Character counter renders in front of input when ta…

c660984

…g is textarea

test(text-field): template test

0d0122f

test(text-field): Useless test for test coverage

81a30f2

test(text-field): unmount test

c808552

test(text-field): screenshot test

c4303eb

test(text-field): add screenshot test url

4a9e9c1

feat(text-field): update golden.json

01437ad

googlebot added the cla: no label May 30, 2019

moog16 changed the base branch from rc0.13.0 to rc0.14.0 May 31, 2019 13:20

Merge branch 'rc0.14.0' into rc0.13.0

b7df35b

test(list): combine character-counter screeneshot

d0a6bb4

moog16 reviewed Jun 3, 2019

View reviewed changes

test/screenshot/text-field/variants.tsx Outdated Show resolved Hide resolved

Update golden.json

ba27ef5

moog16 added cla: yes and removed cla: no labels Jun 3, 2019

fix(text-field): fix lint

963d359

googlebot added cla: no and removed cla: yes labels Jun 3, 2019

moog16 added cla: yes and removed cla: no labels Jun 3, 2019

moog16 merged commit 862e04e into material-components:rc0.14.0 Jun 3, 2019

moog16 mentioned this pull request Jun 3, 2019

Text-Field Character Count #817

Closed

moog16 pushed a commit that referenced this pull request Jun 11, 2019

feat(text-field): character counter (#861)

3525e43

moog16 pushed a commit that referenced this pull request Jun 11, 2019

feat(text-field): character counter (#861)

c3f9439

feat(text-field): character counter #861

feat(text-field): character counter #861

Uh oh!

Conversation

ghost commented May 12, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

codecov-io commented May 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

moog16 left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented May 16, 2019

Uh oh!

moog16 commented May 16, 2019

Uh oh!

ghost commented May 17, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moog16 commented May 17, 2019

Uh oh!

ghost commented May 30, 2019

Uh oh!

moog16 commented May 31, 2019

Uh oh!

ghost commented May 31, 2019

Uh oh!

moog16 commented Jun 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 1, 2019

Uh oh!

Uh oh!

moog16 commented Jun 3, 2019

Uh oh!

googlebot commented Jun 3, 2019

Uh oh!

moog16 commented Jun 3, 2019

Uh oh!

googlebot commented Jun 3, 2019

Uh oh!

ghost commented Jun 3, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moog16 commented Jun 3, 2019

Uh oh!

codecov-io commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

googlebot commented Jun 3, 2019

Uh oh!

Uh oh!

ghost commented May 12, 2019 •

edited by ghost

Loading

codecov-io commented May 12, 2019 •

edited

Loading

ghost commented May 17, 2019 •

edited by ghost

Loading

moog16 commented Jun 1, 2019 •

edited

Loading

ghost commented Jun 3, 2019 •

edited by ghost

Loading

codecov-io commented Jun 3, 2019 •

edited

Loading