This repository was archived by the owner on Jan 14, 2025. It is now read-only.
feat(top-app-bar): TopAppBarFixedAdjust variants added #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc0.8.0 #524 +/- ##
===========================================
+ Coverage 96.62% 96.63% +0.01%
===========================================
Files 59 59
Lines 1984 1991 +7
Branches 235 239 +4
===========================================
+ Hits 1917 1924 +7
Misses 67 67
Continue to review full report at Codecov.
|
moog16
suggested changes
Dec 14, 2018
|
tests: #538 |
|
Test passing and CLA signed in: #524 (comment) merging! |
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This references #518 and can be closed with the previous merging of PR #520.
I am still unsure about screenshot testing. running
yarn capturedid update the correct part's ofgolden.jsonand everything appears as expected fromyarn start.I signed it