This repository was archived by the owner on Jan 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 231
fix(list): minification-safe element type comparison #509
Merged
moog16
merged 3 commits into
material-components:rc0.8.0
from
dan-kwiat:fix/list-item-type
Dec 11, 2018
Merged
fix(list): minification-safe element type comparison #509
moog16
merged 3 commits into
material-components:rc0.8.0
from
dan-kwiat:fix/list-item-type
Dec 11, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc0.8.0 #509 +/- ##
========================================
Coverage 96.62% 96.62%
========================================
Files 59 59
Lines 1984 1984
Branches 235 235
========================================
Hits 1917 1917
Misses 67 67
Continue to review full report at Codecov.
|
b525147
to
5ee55f4
Compare
@dan-kwiat I tested this by
IT WORKED! Thanks again |
TESTS: #511 |
@dan-kwiat while we wait for tests please sign the PR by commenting "I signed it" |
@dan-kwiat can you please add the line found in d7981e2 |
I signed it |
moog16
approved these changes
Dec 11, 2018
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#492
I didn't have a chance to test this - please do so before merging