menu-surface Hoist anti-pattern?

[aluminick]

material-components-web-react/packages/menu-surface/index.tsx

Lines 170 to 172 in 1d08700

	document.body.appendChild(
	menuSurfaceElement.parentElement.removeChild(menuSurfaceElement)
	);

Is this an anti-pattern? I think portal should be used on this one.

[moog16]

@aluminick I am not familiar with react.portals, but after reading the docs I believe you to be correct. Would you like to take a crack at it?

[aluminick]

@moog16 sure. Thanks.

[aluminick]

@moog16 Sorry, I forgot about this issue.
I've hoisted menu-surface using ReactDOM Portal but it has to be wrapped. And the tests are failing.

[moog16]

Oh great - do you have a branch already? Whenever you're ready please feel free to open a PR.

[moog16]

Closed with #693