You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 14, 2025. It is now read-only.
As I work on correcting the missing options of the <TopAppBarFixedAdjust/> (#518) I cannot help but wonder if <TopAppBar> is too verbose. In part because a lot of the options need to be repeated for the fixed adjust and type checking. Why not simplify the whole thing and have a type property?
It is conceivable that a user may want a prominent dense TopAppBar on a desktop, and a fixed variant for a tablet, and a short variant for mobile. It may be a questionable design choice, but simplifying it with a single property sure looks attractive.
Especially when you consider <TopAppBar> also has a lot of long properties already with navigationIcon, and actionItems.
presuming the adoption of type property proves successful the question I have is such a property camelCased? If it were to be delimited with a hyphen it could be useful for class name generation?
Uh oh!
There was an error while loading. Please reload this page.
As I work on correcting the missing options of the
<TopAppBarFixedAdjust/>
(#518) I cannot help but wonder if<TopAppBar>
is too verbose. In part because a lot of the options need to be repeated for the fixed adjust and type checking. Why not simplify the whole thing and have atype
property?Take for example the following
could be rewritten to
That may not look like anything too significant but consider the following.
<TopAppBar prominent short fixed/>
A type property could enforce a single type from a constrained list.<TopAppBar>
also has a lot of long properties already withnavigationIcon
, andactionItems
.presuming the adoption of
type
property proves successful the question I have is such a property camelCased? If it were to be delimited with a hyphen it could be useful for class name generation?Of course a regex that does a conversion could also be whipped up without issue.
Originally posted by @mgr34 in https://github.com/material-components/material-components-web-react/issue_comments#issuecomment-447383027
The text was updated successfully, but these errors were encountered: