Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Commit 42eefd3

Browse files
committed
fix(dialog): make setEscapeKeyAction optional
1 parent a5e8eca commit 42eefd3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/dialog/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@ export interface DialogProps<T,
6161
| React.ReactElement<TitleProps>
6262
);
6363
className?: string;
64-
escapeKeyAction: string;
64+
escapeKeyAction?: string;
6565
id?: string;
6666
onClose?: (action: string) => void;
6767
onClosing?: (action: string) => void;
6868
onOpen?: () => void;
6969
onOpening?: () => void;
7070
open?: boolean;
7171
role?: 'alertdialog' | 'dialog';
72-
scrimClickAction: string;
72+
scrimClickAction?: string;
7373
tag?: string;
7474
};
7575

@@ -143,11 +143,11 @@ class Dialog<T extends HTMLElement = HTMLElement> extends React.Component<
143143
}
144144

145145
if (prevProps.escapeKeyAction !== escapeKeyAction) {
146-
this.foundation.setEscapeKeyAction(escapeKeyAction);
146+
this.foundation.setEscapeKeyAction(escapeKeyAction!);
147147
}
148148

149149
if (prevProps.scrimClickAction !== scrimClickAction) {
150-
this.foundation.setScrimClickAction(scrimClickAction);
150+
this.foundation.setScrimClickAction(scrimClickAction!);
151151
}
152152

153153
if (prevProps.open !== open) {

0 commit comments

Comments
 (0)