Disable buildingsWithUniqueIds setting for MapboxStreets data source. (#655)

* Added workaround to prevent users from accidentally turning on filtering for MapboxStreets building.

* Update changelog

Author: abhishektrip

documentation/docs/05-changelog.md

@@ -9,6 +9,7 @@
 - Add camera script with zoom & pan support for TabletopAR scene.
 
 ##### Bug Fixes
+- Remove `buildingsWithUniqueIds` setting for `Mapbox Streets` data source.
 - Change `Style Name` to `Data Source`
 - Fix to make filter values case insensitive.
 - Fix issue where position vector features was not being set.

sdkproject/Assets/Mapbox/Unity/Editor/PropertyDrawers/VectorLayerPropertiesDrawer.cs

@@ -218,7 +218,7 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
 					var layerProperty = subLayerArray.GetArrayElementAtIndex(SelectionIndex);
 
 					layerProperty.isExpanded = true;
-					DrawLayerVisualizerProperties(layerProperty);
+					DrawLayerVisualizerProperties(sourceTypeValue,layerProperty);
 				}
 				else
 				{
@@ -228,7 +228,7 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
 			EditorGUI.EndProperty();
 		}
 
-		void DrawLayerVisualizerProperties(SerializedProperty layerProperty)
+		void DrawLayerVisualizerProperties(VectorSourceType sourceType, SerializedProperty layerProperty)
 		{
 			EditorGUI.indentLevel++;
 			GUILayout.Label("Vector Layer Visualizer Properties");
@@ -252,12 +252,17 @@ void DrawLayerVisualizerProperties(SerializedProperty layerProperty)
 			EditorGUI.indentLevel++;
 			if (ShowOthers)
 			{
-				if (primitiveTypeProp == VectorPrimitiveType.Polygon)
+				if (primitiveTypeProp == VectorPrimitiveType.Polygon && sourceType != VectorSourceType.MapboxStreets)
 				{
 					EditorGUI.indentLevel--;
+					layerProperty.FindPropertyRelative("honorBuildingIdSetting").boolValue = true;
 					EditorGUILayout.PropertyField(layerProperty.FindPropertyRelative("buildingsWithUniqueIds"), new GUIContent { text = "Buildings With Unique Ids", tooltip = "Turn on this setting only when rendering 3D buildings from the Mapbox Streets with Building Ids tileset. Using this setting with any other polygon layers or source will result in visual artifacts. " });
 					EditorGUI.indentLevel++;
 				}
+				else
+				{
+					layerProperty.FindPropertyRelative("honorBuildingIdSetting").boolValue = false;
+				}
 				EditorGUILayout.PropertyField(layerProperty.FindPropertyRelative("filterOptions"), new GUIContent("Filters"));
 				//EditorGUILayout.PropertyField(layerProperty.FindPropertyRelative("modifierOptions"), new GUIContent("Modifiers"));
 				DrawModifiers(layerProperty, new GUIContent { text = "Modifier Options", tooltip = "Additional Feature modifiers to apply to the visualizer. " });

sdkproject/Assets/Mapbox/Unity/LayerProperties/VectorSubLayerProperties.cs

@@ -22,7 +22,8 @@ public class VectorSubLayerProperties : LayerProperties
 			colliderType = ColliderType.None,
 		};
 		public GeometryMaterialOptions materialOptions = new GeometryMaterialOptions();
-
+		//HACK : workaround to avoid users accidentaly leaving the buildingsWithUniqueIds settign on and have missing buildings. 
+		public bool honorBuildingIdSetting = true;
 		public bool buildingsWithUniqueIds = false;
 		public PositionTargetType moveFeaturePositionTo;
 		[NodeEditorElement("Mesh Modifiers")]

sdkproject/Assets/Mapbox/Unity/MeshGeneration/LayerVisualizers/VectorLayerVisualizer.cs

@@ -214,10 +214,13 @@ private IEnumerator ProcessLayer(VectorTileLayer layer, UnityTile tile, Action c
 			for (int i = 0; i < fc; i++)
 			{
 
-				var feature = new VectorFeatureUnity(layer.GetFeature(i), tile, layer.Extent, _layerProperties.buildingsWithUniqueIds);
+				var buildingsWithUniqueIds =
+					(_layerProperties.honorBuildingIdSetting) && _layerProperties.buildingsWithUniqueIds;
+
+				var feature = new VectorFeatureUnity(layer.GetFeature(i), tile, layer.Extent, buildingsWithUniqueIds);
 
 				//skip existing features, only works on tilesets with unique ids
-				if (_layerProperties.buildingsWithUniqueIds && _activeIds.Contains(feature.Data.Id))
+				if (buildingsWithUniqueIds && _activeIds.Contains(feature.Data.Id))
 				{
 					continue;
 				}