Skip to content

Commit 9e8971a

Browse files
Include 'exit roundabout' in Navigation Constants (#1628)
Update maneuver types based on latest values and order documented
1 parent a2a5a72 commit 9e8971a

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/maneuver/ManeuverView.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_MODIFIER_UTURN;
2828
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_ARRIVE;
2929
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_EXIT_ROTARY;
30+
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants
31+
.STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT;
3032
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_FORK;
3133
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_OFF_RAMP;
3234
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_ROTARY;
@@ -59,6 +61,8 @@ public class ManeuverView extends View {
5961
add(STEP_MANEUVER_TYPE_ROTARY);
6062
add(STEP_MANEUVER_TYPE_ROUNDABOUT);
6163
add(STEP_MANEUVER_TYPE_ROUNDABOUT_TURN);
64+
add(STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT);
65+
add(STEP_MANEUVER_TYPE_EXIT_ROTARY);
6266
}
6367
};
6468
private static final Set<String> MANEUVER_TYPES_WITH_NULL_MODIFIERS = new HashSet<String>() {
@@ -67,6 +71,7 @@ public class ManeuverView extends View {
6771
add(STEP_MANEUVER_TYPE_FORK);
6872
add(STEP_MANEUVER_TYPE_ROUNDABOUT);
6973
add(STEP_MANEUVER_TYPE_ROUNDABOUT_TURN);
74+
add(STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT);
7075
add(STEP_MANEUVER_TYPE_ROTARY);
7176
add(STEP_MANEUVER_TYPE_EXIT_ROTARY);
7277
}

libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/maneuver/ManeuverViewMap.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_MODIFIER_UTURN;
1717
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_ARRIVE;
1818
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_EXIT_ROTARY;
19+
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants
20+
.STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT;
1921
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_FORK;
2022
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_MERGE;
2123
import static com.mapbox.services.android.navigation.v5.navigation.NavigationConstants.STEP_MANEUVER_TYPE_OFF_RAMP;
@@ -61,6 +63,13 @@ public void updateManeuverView(Canvas canvas, int primaryColor, int secondaryCol
6163
ManeuversStyleKit.drawRoundabout(canvas, primaryColor, secondaryColor, size, roundaboutAngle);
6264
}
6365
});
66+
put(new Pair<String, String>(STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT, null), new ManeuverViewUpdate() {
67+
@Override
68+
public void updateManeuverView(Canvas canvas, int primaryColor, int secondaryColor,
69+
PointF size, float roundaboutAngle) {
70+
ManeuversStyleKit.drawRoundabout(canvas, primaryColor, secondaryColor, size, roundaboutAngle);
71+
}
72+
});
6473
put(new Pair<String, String>(STEP_MANEUVER_TYPE_ROTARY, null), new ManeuverViewUpdate() {
6574
@Override
6675
public void updateManeuverView(Canvas canvas, int primaryColor, int secondaryColor,

libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationConstants.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,10 @@ private NavigationConstants() {
168168
public static final String STEP_MANEUVER_TYPE_CONTINUE = "continue";
169169
public static final String STEP_MANEUVER_TYPE_ROUNDABOUT = "roundabout";
170170
public static final String STEP_MANEUVER_TYPE_ROTARY = "rotary";
171-
public static final String STEP_MANEUVER_TYPE_EXIT_ROTARY = "exit rotary";
172171
public static final String STEP_MANEUVER_TYPE_ROUNDABOUT_TURN = "roundabout turn";
173172
public static final String STEP_MANEUVER_TYPE_NOTIFICATION = "notification";
173+
public static final String STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT = "exit roundabout";
174+
public static final String STEP_MANEUVER_TYPE_EXIT_ROTARY = "exit rotary";
174175

175176
@StringDef( {
176177
STEP_MANEUVER_TYPE_TURN,
@@ -186,7 +187,9 @@ private NavigationConstants() {
186187
STEP_MANEUVER_TYPE_ROUNDABOUT,
187188
STEP_MANEUVER_TYPE_ROTARY,
188189
STEP_MANEUVER_TYPE_ROUNDABOUT_TURN,
189-
STEP_MANEUVER_TYPE_NOTIFICATION
190+
STEP_MANEUVER_TYPE_NOTIFICATION,
191+
STEP_MANEUVER_TYPE_EXIT_ROUNDABOUT,
192+
STEP_MANEUVER_TYPE_EXIT_ROTARY
190193
})
191194
public @interface ManeuverType {
192195
}

0 commit comments

Comments
 (0)