httprouter.go Need Type Assertion

[Linuturk]

Hey guys,

Not sure why I'm getting this error when I attempt to build with api2go:

github.com/manyminds/api2go/routing/httprouter.go:51: cannot use notAllowedHandler (type http.Handler) as type http.HandlerFunc in assignment: need type assertion

Seems to be this line here: https://github.com/manyminds/api2go/blob/master/routing/httprouter.go#L51

If I comment this out everything seems to validate fine. Given the code in that section is from two years ago, I imagine there's just a small tweak that needs to be made?

[sharpner]

Can you show us how you are using it? A bit of code might help to find the problem.

[sharpner]

Tried to dig into this blindly, but I can't reproduce any error:

package main
import (
        "fmt"
        "net/http"
        "github.com/manyminds/api2go"
        "github.com/manyminds/api2go/routing"
)
func test() http.Handler {
        return nil
}
func main() {
        routing.NewHTTPRouter("a", test())
        test := api2go.NewAPIWithBaseURL("/", "/")
        fmt.Printf("%'v", test)
}

works as expected. Maybe you are having an outdated version of httprouter or any other dependency.. possibly try updating them first and then we can search further :)

[Linuturk]

Yeah, sorry for the lack of context.

$ go version
go version go1.9.1 linux/amd64

Here are the related sections of dep status, just updated yesterday before submitting the issue.

github.com/gorilla/context           *              v1.1           1ea2538   1ea2538  1  
github.com/gorilla/handlers          ^1.2.1         v1.2.1         a4043c6   a4043c6  1  
github.com/gorilla/mux               ^1.4.0         v1.5.0         24fca30   24fca30  1
github.com/manyminds/api2go          *              0.6            02704db   02704db  3 
github.com/manyminds/api2go-adapter  *              branch master  13346ba   13346ba  1

Was trying to figure out how to integrate into my existing code base that uses gorilla mux. I found this Example and tried to go down this route: https://github.com/manyminds/api2go-adapter/tree/master/gorillamux

	r := mux.NewRouter()
	api := api2go.NewAPIWithRouting(
		"api",
		api2go.NewStaticResolver("/"),
		api2go.DefaultContentMarshalers,
		gorillamux.New(r),
	)
... r.HandleFunc routes here ...
... LIstenAndServe...

Results in the error I initially reported.

[Linuturk]

Related to manyminds/api2go-adapter#5 it seems.

[sharpner]

so it is fixed for you?

[Linuturk]

No, when I have the above code snippet as provided in the gorillamux adapter example, I get the error in the initial report.

[sharpner]

ah sry I overlooked that one comment :)

[sharpner]

Ah I see now you are using an old version of api2go from november 2015..... puh it's hard to provide any help here, but I would guess that the adapter version would be too new...

[Linuturk]

Is this the recommended way to connect api2go to gorilla mux, or would you recommend a different method?

[sharpner]

Currently that's the way to do it, I just tested it:

package main
import (
        "net/http"
        "github.com/gorilla/mux"
        "github.com/manyminds/api2go"
        "github.com/manyminds/api2go-adapter/gorillamux"
)
func main() {
        r := mux.NewRouter()
        api := api2go.NewAPIWithRouting(
                "api",
                api2go.NewStaticResolver("/"),
                gorillamux.New(r),
        )
        // Add your API resources here...
        // see https://github.com/manyminds/api2go for more information
        r.HandleFunc("/ping", func(w http.ResponseWriter, r *http.Request) {
                w.WriteHeader(http.StatusOK)
                w.Write([]byte("pong"))
        }).Methods("GET")
        http.Handle("/api", api.Handler())
        http.Handle("/", r)
        http.ListenAndServe(":2020", nil)
}

this will work with all versions on master. On version 0.6 somethings might be a lot different. But I understand the confusion, the Readme.md in the adapter package is outdated... We will improve and update all documentation. That should not happen - sorry :/

[Linuturk]

Here's a larger snippet of my code:

package mypackage

import (
	"encoding/json"
	"fmt"
	"log"
	"net/http"

	"github.com/gorilla/handlers"
	"github.com/gorilla/mux"
	"github.com/manyminds/api2go"
	"github.com/manyminds/api2go-adapter/gorillamux"
)

// Handler creates and returns a logging handler
func Handler() http.Handler {
	// new mux
	r := mux.NewRouter()
	api := api2go.NewAPIWithRouting(
		"api",
		api2go.NewStaticResolver("/"),
		gorillamux.New(r),
	)

	// Index, Healthcheck
	r.HandleFunc("/", Index)
	r.HandleFunc("/healthcheck", HealthCheck)

... snip a bunch of r.HandleFunc calls to various endpoints/functions ...

	// api handler
	http.Handle("api", api.Handler())
	http.Handle("/", r)

	// create a logging handler
	h := handlers.LoggingHandler(logFile(), r)

	// wrap with CORS handler
	h = handlers.CORS()(h)

	// return a logging handler
	log.Println("Server now active...")

	return h
}
... HandleFunc targets ...

Then in my daemon, I'm calling:

... snip database setup ...
	// launch http service
	log.Printf("Launching server on http://localhost%v\n", port)
	log.Fatal(http.ListenAndServe(port, mypackage.Handler()))
}

This all still results in github.com/manyminds/api2go/routing/httprouter.go:51: cannot use notAllowedHandler (type http.Handler) as type http.HandlerFunc in assignment: need type assertion message.

[sharpner]

Yeah... well the fact that NewAPIWithRouting in your example takes four parameters, makes sure that it's an outdated version. You should update to the newest version first, otherwise it's hard to provide any advice that's helpful...

[Linuturk]

Updated to match your example.

Still running the latest versions based on the dep status from before . . . so I'm not sure how I'm out of date.

github.com/manyminds/api2go          *              0.6            02704db   02704db  3
github.com/manyminds/api2go-adapter  *              branch master  13346ba   13346ba  1

[Linuturk]

Ok, I think I understand now.

It seems that since you used to tag releases, dep picks up on 0.6.0 and uses that by default. I updated my Gopkg.toml to install via the master branch instead of the tag. Now that function takes 3 arguments.

You might want to tag a more recent commit as a newer release. https://github.com/golang/dep

With that in mind, I still had to change a portion of the code.

github.com/manyminds/api2go/routing/httprouter.go line 51 from router.MethodNotAllowed = notAllowedHandler to router.MethodNotAllowed = notAllowedHandler.(http.HandlerFunc)

Do you want a PR to that effect?