feat: enforces https for article viewers, removes outdated article readers such as

1. google gwt
2. view text

Author: Joice M. Joseph

app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java

@@ -42,9 +42,7 @@ public class ArticleReaderActivity extends AppCompatActivity {
   public static final String EXTRA_HNPOST = "HNPOST";
   public static final String EXTRA_HTMLPROVIDER_OVERRIDE = "HTMLPROVIDER_OVERRIDE";
 
-  private static final String HTMLPROVIDER_PREFIX_VIEWTEXT = "http://viewtext.org/article?url=";
-  private static final String HTMLPROVIDER_PREFIX_GOOGLE = "http://www.google.com/gwt/x?u=";
-  private static final String HTMLPROVIDER_PREFIX_INSTAPAPER = "http://www.instapaper.com/text?u=";
+  private static final String HTMLPROVIDER_PREFIX_INSTAPAPER = "https://www.instapaper.com/text?u=";
 
   @ViewById(R.id.article_webview)
   WebView mWebView;
@@ -187,11 +185,7 @@ private void toggleSwipeRefreshLayout() {
   @SuppressWarnings("deprecation")
   public static String getArticleViewURL( HNPost post, String htmlProvider, Context c ) {
     String encodedURL = URLEncoder.encode( post.getURL() );
-    if (htmlProvider.equals( c.getString( R.string.pref_htmlprovider_viewtext ) )) {
-      return HTMLPROVIDER_PREFIX_VIEWTEXT + encodedURL;
-    } else if (htmlProvider.equals( c.getString( R.string.pref_htmlprovider_google ) )) {
-      return HTMLPROVIDER_PREFIX_GOOGLE + encodedURL;
-    } else if (htmlProvider.equals( c.getString( R.string.pref_htmlprovider_instapaper ) )) {
+    if (htmlProvider.equals( c.getString( R.string.pref_htmlprovider_instapaper ) )) {
       return HTMLPROVIDER_PREFIX_INSTAPAPER + encodedURL;
     } else {
       return post.getURL();

app/src/main/java/com/manuelmaly/hn/MainActivity.java

@@ -603,8 +603,6 @@ public LongPressMenuListAdapter(HNPost post) {
             }
             mItems.addAll(Arrays.asList(
                     getString(R.string.pref_htmlprovider_original_url),
-                    getString(R.string.pref_htmlprovider_viewtext),
-                    getString(R.string.pref_htmlprovider_google),
                     getString(R.string.pref_htmlprovider_instapaper),
                     getString(R.string.external_browser),
                     getString(R.string.share_article_url)));

app/src/main/res/values/preference_values.xml

@@ -16,14 +16,10 @@
     <string name="pref_title_htmlprovider">View Articles via &#8230;</string>
     <string name="pref_default_htmlprovider">Original Article URL</string>
     <string name="pref_htmlprovider_original_url">Original Article URL</string>
-    <string name="pref_htmlprovider_viewtext">ViewText.org</string>
-    <string name="pref_htmlprovider_google">Google for Mobile Devices</string>
     <string name="pref_htmlprovider_instapaper">Instapaper Text</string>
 
     <string-array name="pref_array_htmlprovider">
         <item>@string/pref_htmlprovider_original_url</item>
-        <item>@string/pref_htmlprovider_viewtext</item>
-        <item>@string/pref_htmlprovider_google</item>
         <item>@string/pref_htmlprovider_instapaper</item>
     </string-array>