Skip to content

pytest-server-fixture: Update RethinkDB fixtures to support rethinkdb >= 2.4.0 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcfr opened this issue Mar 7, 2019 · 2 comments
Closed

Comments

@jcfr
Copy link
Contributor

jcfr commented Mar 7, 2019

Problem: Using the latest version of the python package causes the tests/integration/test_rethink_server.py to fail.

Background: Since the API associated with the latest release of rethinkdb-python package released on March 2nd 2019 is backward incompatible, the implementation of the RethinkDB fixtures need to be updated.

See https://github.com/rethinkdb/rethinkdb-python/releases/tag/v2.4.0

jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 20, 2019
----
ci: Test against Python 3.7

----
ci: Skip Coveralls submission if COVERALLS_REPO_TOKEN env. var is empty

----
ci: Update circleci image to allow install of python 3.7
See https://circleci.com/docs/2.0/configuration-reference/#machine

----
pytest-server-fixture: Fix rethinkdb tests requiring rethinkdb < 2.4.0

The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132

----
wheels: Generate universal wheels installable with both python 2.x and 3.x
See man-group#125

Fix DeprecationWarning warnings using "logger.warning()" function

----
pytest-virtualenv: Add virtualenv as install requirement. Fixes man-group#122

Remove requirement for pytest<4.0.0
See man-group#100

----
pytest-webdriver: Fix RemovedInPytest4Warning using getfixturevalue

This commit fixes the following error:

  >           root_uri.append(request.getfuncargvalue('pyramid_server').uri)
  E           RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

  pytest_webdriver.py:62: RemovedInPytest4Warning

See man-group#100

----
pytest-verbose-parametrize: Add support for revamped marker infrastructure

This commit fixes tests failing with pytest > 4.0.0

----
pytest-verbose-parametrize: Fix integration tests to support pytest >= 4.1.0

This commit updates tests to support version of pytest with
pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

----
dist: Remove support for building and distributing *.egg files

Wheel is currently considered the standard for built and binary
packaging for Python

See https://packaging.python.org/discussions/wheel-vs-egg/

See man-group#125

----
VagrantFile: Install python 3.7 and initialize python 3.7 by default
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 20, 2019
----
ci: Test against Python 3.7

----
ci: Skip Coveralls submission if COVERALLS_REPO_TOKEN env. var is empty

----
ci: Update circleci image to allow install of python 3.7
See https://circleci.com/docs/2.0/configuration-reference/#machine

----
pytest-server-fixture: Fix rethinkdb tests requiring rethinkdb < 2.4.0

The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132

----
wheels: Generate universal wheels installable with both python 2.x and 3.x
See man-group#125

Fix DeprecationWarning warnings using "logger.warning()" function

----
pytest-virtualenv: Add virtualenv as install requirement. Fixes man-group#122

Remove requirement for pytest<4.0.0
See man-group#100

----
pytest-webdriver: Fix RemovedInPytest4Warning using getfixturevalue

This commit fixes the following error:

  >           root_uri.append(request.getfuncargvalue('pyramid_server').uri)
  E           RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

  pytest_webdriver.py:62: RemovedInPytest4Warning

See man-group#100

----
pytest-verbose-parametrize: Add support for revamped marker infrastructure

This commit fixes tests failing with pytest > 4.0.0

----
pytest-verbose-parametrize: Fix integration tests to support pytest >= 4.1.0

This commit updates tests to support version of pytest with
pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

----
dist: Remove support for building and distributing *.egg files

Wheel is currently considered the standard for built and binary
packaging for Python

See https://packaging.python.org/discussions/wheel-vs-egg/

See man-group#125

----
VagrantFile: Install python 3.7 and initialize python 3.7 by default
@eeaston
Copy link
Collaborator

eeaston commented Mar 20, 2019

Thanks for raising - gosh I'm surprised the driver was updated since the database itself has ceased supported development a few years ago now.

@eeaston
Copy link
Collaborator

eeaston commented May 28, 2019

Fixed in #134

@eeaston eeaston closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants