Commit bf42aa4
authored
fix: Derive
# Problem
The derive macro `GetTypeDependencies` required the
`bevy_mod_scripting_core` to be an explicit dependency for users.
# Solution
I altered it to refer to `::bevy_mod_scripting::core` instead of
`bevy_mod_scripting_core` so that it works with the usual dependency of
`bevy_mod_scripting`.
# Alternative
The user can add "bevy_mod_scripting_core" as a dependency.
## Testing
- It works in my project now.
- I did not add a test.
- I did run the tests; there were two unrelated failures that I looked
into but it wasn't clear to me how to fix it.
```
error[E0433]: failed to resolve: could not find `function_scope` in `profiling`
--> crates/bevy_mod_scripting_core/src/bindings/globals/core.rs:29:20
|
29 | profiling::function_scope!("app finish");
| ^^^^^^^^^^^^^^ could not find `function_scope` in `profiling`
error[E0433]: failed to resolve: could not find `function_scope` in `profiling`
--> crates/bevy_mod_scripting_core/src/bindings/globals/core.rs:88:20
|
88 | profiling::function_scope!("registering core globals");
| ^^^^^^^^^^^^^^ could not find `function_scope` in `profiling`
```GetTypeDependency without explicit "core" dependency. (#409)1 parent 87d1f14 commit bf42aa4
File tree
1 file changed
+1
-1
lines changed- crates/bevy_mod_scripting_derive/src/derive
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
0 commit comments