Skip to content

Fix Issue: “Asymmetric transaction rollback error” if commit callbacks throw exceptions #9955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 11, 2017
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
141fa5e
testing travis
waynetheisinger Jun 2, 2017
e3a164e
Merge remote-tracking branch 'upstream/develop' into develop
waynetheisinger Jun 12, 2017
6514707
Merge remote-tracking branch 'upstream/develop' into develop
waynetheisinger Jun 14, 2017
f0b320b
Add AfterCommitException
waynetheisinger Jun 14, 2017
6970611
Throw new AfterCommitException from AbstractResource.php
waynetheisinger Jun 14, 2017
1cc3787
Catch AfterCommitException from AbstractResource.php
waynetheisinger Jun 14, 2017
4663581
Delete forcing file that was used to nudge travis
waynetheisinger Jun 14, 2017
465b591
Fix Code Style
waynetheisinger Jun 14, 2017
08d737f
Merge branch 'develop' of github.com:waynetheisinger/magento2 into de…
waynetheisinger Jun 14, 2017
7e30967
Suppress CyclomaticComplexity Warning - Discuss with Core Team
waynetheisinger Jun 14, 2017
95c2ae9
Alter Tests to add new exception catches (plus a few main catches)
waynetheisinger Jun 15, 2017
973eb08
Merge remote-tracking branch 'upstream/develop' into develop
waynetheisinger Jun 15, 2017
0d42133
Revert "Alter Tests to add new exception catches (plus a few main cat…
waynetheisinger Jun 15, 2017
d1b891a
Revert "Suppress CyclomaticComplexity Warning - Discuss with Core Team"
waynetheisinger Jun 14, 2017
7b813c2
Revert "Fix Code Style"
waynetheisinger Jun 14, 2017
b672c4e
Revert "Catch AfterCommitException from AbstractResource.php"
waynetheisinger Jun 14, 2017
12631c0
Revert "Throw new AfterCommitException from AbstractResource.php"
waynetheisinger Jun 14, 2017
0c886ca
Revert "Add AfterCommitException"
waynetheisinger Jun 14, 2017
e2c1bb7
Instead of throwing exception - just log
waynetheisinger Jul 7, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function commit()
call_user_func($callback);
}
} catch (\Exception $e) {
throw $e;
$this->logger->critical($e);
}
}
return $this;
Expand Down