Skip to content

Add php value for setting auto_detect_line_endings on. #6492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

philcook
Copy link

@philcook philcook commented Sep 5, 2016

This PR is to fix issue #6393

The default for auto_detect_line_endings when PHP is installed is off therefore to stop other users of magento falling into this issue the htaccess file can cover this off.

Thanks for considering.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 5, 2016

CLA assistant check
All committers have signed the CLA.

@okorshenko
Copy link
Contributor

Hi @philcook
Thank you for your contribution. Unfortunately, we can not accept this pull requests. PHP itself does not recommend enable this option

This enables PHP to interoperate with Macintosh systems, but defaults to Off, as there is a very small performance penalty when detecting the EOL conventions for the first line, and also because people using carriage-returns as item separators under Unix systems would experience non-backwards-compatible behaviour.

We don't want to change this behaviour on Magento framework level.
Thank you

@okorshenko okorshenko closed this Jun 14, 2017
@magento magento locked and limited conversation to collaborators Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants